From: "Philip Oakley" <philipoakley@iee.org>
To: "Junio C Hamano" <gitster@pobox.com>, "David Aguilar" <davvid@gmail.com>
Cc: "GitList" <git@vger.kernel.org>
Subject: Re: [PATCH 01/13] Use 'Git' in help messages
Date: Tue, 26 Feb 2013 22:56:07 -0000 [thread overview]
Message-ID: <96C279DB1BA3478ABA712FF00EAB6C13@PhilipOakley> (raw)
From: "Philip Oakley" <philipoakley@iee.org>
Sent: Sunday, February 24, 2013 9:50 PM
> From: "Junio C Hamano" <gitster@pobox.com>
> Sent: Sunday, February 24, 2013 8:59 AM
>> David Aguilar <davvid@gmail.com> writes:
>>
>>> This is referring to "git the command", not "git the system",
>>> so it should not be changed according to the rule that was
>>> applied when many "git" strings were changed to "Git".
>>
>> That sounds like a sensible objection.
>>
>
> I'd read the messages in the tone 'commands of the Git system', but I
> can see that both views are equally plausible. Though the final
> _("git: '%s' is not a Git command. See 'git --help'.") can't be
> referring to a 'git-<cmd>', obviously ;-)
>
>>> There are scripts, etc. in the wild that parse this output.
>>> which is another reason we would not want to change this.
>>
>> Are there? For what purpose?
>>
Just found that Git Gui checks for the version number (line 936)
if {![regsub {^git version } $_git_version {} _git_version]} {
and then parses for the dot separated digits etc.
So looks like the version string change would be a problematic
regression.
Given the change elsewhere of 'Usage:' to 'usage:' it looks like I
should drop this patch.
>> Especially when these are all _("l10n ready"), I find that somewhat
>> unlikely.
>>
>> The bash completion (in contrib/) does read from the command list
>> IIRC. I do not think it relies on the messages, though.
>
> I was aware of that bash completion used 'git help -a' so I avoided
> changing the response to that option. Initially I'd thought of making
> '-a' provide both commands and guides but knew I'd need to ensure the
> completion would still be sensible. I'd taken Juio's earlier advice to
> keep '-a' unchanged and simply add the -g|--guides option as a
> supplemental 'git help' response..
>
> Philip
next reply other threads:[~2013-02-26 22:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-26 22:56 Philip Oakley [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-02-23 23:05 [PATCH 00/13] Git help option to list user guides Philip Oakley
2013-02-23 23:05 ` [PATCH 01/13] Use 'Git' in help messages Philip Oakley
2013-02-23 23:41 ` David Aguilar
2013-02-23 23:54 ` Philip Oakley
2013-02-24 8:59 ` Junio C Hamano
2013-02-24 21:50 ` Philip Oakley
2013-02-24 22:11 ` David Aguilar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96C279DB1BA3478ABA712FF00EAB6C13@PhilipOakley \
--to=philipoakley@iee.org \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).