From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 800131F45E for ; Mon, 17 Feb 2020 17:40:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729517AbgBQRkQ (ORCPT ); Mon, 17 Feb 2020 12:40:16 -0500 Received: from smtprelay01.ispgateway.de ([80.67.31.24]:12852 "EHLO smtprelay01.ispgateway.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726818AbgBQRkQ (ORCPT ); Mon, 17 Feb 2020 12:40:16 -0500 Received: from [24.134.116.61] (helo=[192.168.92.208]) by smtprelay01.ispgateway.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92.3) (envelope-from ) id 1j3k9P-0006a6-1q; Mon, 17 Feb 2020 18:25:43 +0100 Subject: Re: [PATCH 2/8] rm: support the --pathspec-from-file option To: Junio C Hamano Cc: Alexandr Miloslavskiy via GitGitGadget , git@vger.kernel.org, Paul-Sebastian Ungureanu References: <5611e3ae326bb7f61abf870e3b2851226b6af1d8.1579190965.git.gitgitgadget@gmail.com> <19ab18db-3149-02b1-41d8-7ddb42c3757d@syntevo.com> From: Alexandr Miloslavskiy Message-ID: <8e24eab8-fc75-d676-8b11-ee01355813c4@syntevo.com> Date: Mon, 17 Feb 2020 18:25:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Df-Sender: YWxleGFuZHIubWlsb3NsYXZza2l5QHN5bnRldm8uY29t Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 10.02.2020 19:48, Junio C Hamano wrote: > I expected that the proposed log message to explain and justify why > a change (in behaviour, in design, etc.) is made. "There is this > limitation" is not a justification---"because of such and such > reasons, there is this limitation, otherwise such and such bad > things happen" is. I have rewritten the commit message in V3. Is that better?