From: "Antoine Beaupré" <anarcat@debian.org>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Git List <git@vger.kernel.org>, Kevin <kevin@ki-ai.org>
Subject: Re: [PATCH 1/4] remote-mediawiki: add namespace support
Date: Sun, 29 Oct 2017 14:29:38 -0400 [thread overview]
Message-ID: <87a809959p.fsf@curie.anarc.at> (raw)
In-Reply-To: <CAPig+cSmfJ2Uv21Q4DgJNoy6Ywj7GWPJa6qq0YL9Kar6Q74a_Q@mail.gmail.com>
On 2017-10-29 13:24:03, Eric Sunshine wrote:
> On Sun, Oct 29, 2017 at 12:08 PM, Antoine Beaupré <anarcat@debian.org> wrote:
>> From: Kevin <kevin@ki-ai.org>
>>
>> this introduces a new remote.origin.namespaces argument that is a
>
> s/this/This/
ack.
>> space-separated list of namespaces. the list of pages extract is then
>
> s/the/The/
ack.
>> taken from all the specified namespaces.
>>
>> Reviewed-by: Antoine Beaupré <anarcat@debian.org>
>> Signed-off-by: Antoine Beaupré <anarcat@debian.org>
>> ---
>> diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl b/contrib/mw-to-git/git-remote-mediawiki.perl
>> @@ -1331,7 +1356,12 @@ sub get_mw_namespace_id {
>> sub get_mw_namespace_id_for_page {
>> my $namespace = shift;
>> if ($namespace =~ /^([^:]*):/) {
>
> This is not a new issue, but why capture if $1 is never referenced in
> the code below?
meh, i dunno.
>> - return get_mw_namespace_id($namespace);
>> + my ($ns, $id) = split(/:/, $namespace);
>> + if (Scalar::Util::looks_like_number($id)) {
>> + return get_mw_namespace_id($ns);
>
> So, the idea is that if the input has form "something:number", then
> you want to look up "something" as a namespace name. Anything else
> (such as "something:foobar") is not considered a valid page reference.
> Right?
frankly, i have no idea what's going on here.
>> + } else{
>
> Missing space before open brace.
right.
>> + return
>
> Not required, but missing semi-colon.
ok.
>> + }
>> } else {
>> return;
>> }
>
> The multiple 'return's are a bit messy. Perhaps collapse the entire
> function to something like this:
>
> sub get_mw_namespace_id_for_page {
> my $arg = shift;
> if ($arg =~ /^([^:]+):\d+$/) {
> return get_mw_namespace_id($1);
> }
> return undef;
> }
>
> Then, you don't need even need Scalar::Util::looks_like_number()
> (unless, I suppose, the incoming number is expected to be something
> other than simple digits).
>
> In fact, it may be that the intent of the original code *was* meant to
> do exactly the same as shown in my example above, but that the person
> who wrote it accidentally typed:
>
> return get_mw_namespace_id($namespace);
>
> instead of the intended:
>
> return get_mw_namespace_id($1);
>
> So, a minimal fix would be simply to change $namespace to $1.
> Tightening the regex as I did in my example would be a bonus (though
> probably ought to be a separate patch).
so while i'm happy to just copy-paste your code in there, that's kind of
a sensitive area of the code, as it was originally used only in the
upload procedure, which I haven't tested at all. so i'm hesitant in just
merging that in as is.
i don't understand why or how this even works, to be honest: page names
don't necessarily look like numbers, in fact, they generally don't. i
don't understand why the patch submitted here even touches that function
at all, considering that the function is only used on uploads. I just
cargo-culted it from the original issue...
sigh.
a.
--
C'est trop facile quand les guerres sont finies
D'aller gueuler que c'était la dernière
Amis bourgeois vous me faites envie
Ne voyez vous pas donc point vos cimetières?
- Jaques Brel
next prev parent reply other threads:[~2017-10-29 18:39 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-29 16:08 [PATCH 0/4] WIP: git-remote-media wiki namespace support Antoine Beaupré
2017-10-29 16:08 ` [PATCH 1/4] remote-mediawiki: add " Antoine Beaupré
2017-10-29 17:24 ` Eric Sunshine
2017-10-29 18:29 ` Antoine Beaupré [this message]
2017-10-29 20:07 ` Eric Sunshine
2017-10-29 23:08 ` Kevin
2017-10-30 2:14 ` Antoine Beaupré
2017-10-30 2:51 ` [PATCH v2 0/7] " Antoine Beaupré
2017-10-30 2:51 ` [PATCH 1/7] " Antoine Beaupré
2017-10-30 2:51 ` [PATCH 2/7] remote-mediawiki: allow fetching namespaces with spaces Antoine Beaupré
2017-10-30 2:51 ` [PATCH 3/7] remote-mediawiki: show known namespace choices on failure Antoine Beaupré
2017-10-30 2:51 ` [PATCH 4/7] remote-mediawiki: skip virtual namespaces Antoine Beaupré
2017-11-01 13:52 ` Eric Sunshine
2017-11-01 16:45 ` Antoine Beaupré
2017-11-02 1:24 ` Junio C Hamano
2017-11-02 21:20 ` Antoine Beaupré
2017-11-06 0:38 ` Junio C Hamano
2017-10-30 2:51 ` [PATCH 5/7] remote-mediawiki: support fetching from (Main) namespace Antoine Beaupré
2017-11-01 19:56 ` Eric Sunshine
2017-11-02 21:19 ` Antoine Beaupré
2017-10-30 2:51 ` [PATCH 6/7] remote-mediawiki: process namespaces in order Antoine Beaupré
2017-11-01 19:59 ` Eric Sunshine
2017-10-30 2:51 ` [PATCH 7/7] remote-mediawiki: show progress while fetching namespaces Antoine Beaupré
2017-11-01 20:01 ` Eric Sunshine
2017-11-02 21:25 ` [PATCH v3 0/7] remote-mediawiki: namespace support Antoine Beaupré
2017-11-02 21:25 ` [PATCH v3 1/7] remote-mediawiki: add " Antoine Beaupré
2017-11-02 21:25 ` [PATCH v3 2/7] remote-mediawiki: allow fetching namespaces with spaces Antoine Beaupré
2017-11-02 21:25 ` [PATCH v3 3/7] remote-mediawiki: show known namespace choices on failure Antoine Beaupré
2017-11-02 21:25 ` [PATCH v3 4/7] remote-mediawiki: skip virtual namespaces Antoine Beaupré
2017-11-02 22:43 ` Eric Sunshine
2017-11-02 22:54 ` Antoine Beaupré
2017-11-02 21:25 ` [PATCH v3 5/7] remote-mediawiki: support fetching from (Main) namespace Antoine Beaupré
2017-11-02 22:48 ` Eric Sunshine
2017-11-02 21:25 ` [PATCH v3 6/7] remote-mediawiki: process namespaces in order Antoine Beaupré
2017-11-02 22:49 ` Eric Sunshine
2017-11-02 21:25 ` [PATCH v3 7/7] remote-mediawiki: show progress while fetching namespaces Antoine Beaupré
2017-11-02 22:18 ` Thomas Adam
2017-11-02 22:26 ` Antoine Beaupré
2017-11-02 22:31 ` Thomas Adam
2017-11-02 23:10 ` Antoine Beaupré
2017-11-04 9:57 ` Thomas Adam
2017-11-02 22:50 ` Eric Sunshine
2017-11-06 21:19 ` [PATCH v4 0/7] remote-mediawiki: namespace support Antoine Beaupré
2017-11-06 21:19 ` [PATCH v4 1/7] remote-mediawiki: add " Antoine Beaupré
2017-11-06 21:19 ` [PATCH v4 2/7] remote-mediawiki: allow fetching namespaces with spaces Antoine Beaupré
2017-11-07 7:08 ` Thomas Adam
2017-11-07 16:03 ` Antoine Beaupré
2017-11-06 21:19 ` [PATCH v4 3/7] remote-mediawiki: show known namespace choices on failure Antoine Beaupré
2017-11-07 10:45 ` Thomas Adam
2017-11-07 16:07 ` Antoine Beaupré
2017-11-06 21:19 ` [PATCH v4 4/7] remote-mediawiki: skip virtual namespaces Antoine Beaupré
2017-11-06 21:19 ` [PATCH v4 5/7] remote-mediawiki: support fetching from (Main) namespace Antoine Beaupré
2017-11-06 21:19 ` [PATCH v4 6/7] remote-mediawiki: process namespaces in order Antoine Beaupré
2017-11-06 21:19 ` [PATCH v4 7/7] remote-mediawiki: show progress while fetching namespaces Antoine Beaupré
2017-11-07 16:06 ` [PATCH v5 0/7] namespace support Antoine Beaupré
2017-11-07 16:06 ` [PATCH v5 1/7] remote-mediawiki: add " Antoine Beaupré
2017-11-07 16:06 ` [PATCH v5 2/7] remote-mediawiki: allow fetching namespaces with spaces Antoine Beaupré
2017-11-07 16:06 ` [PATCH v5 3/7] remote-mediawiki: show known namespace choices on failure Antoine Beaupré
2017-11-07 16:06 ` [PATCH v5 4/7] remote-mediawiki: skip virtual namespaces Antoine Beaupré
2017-11-07 16:06 ` [PATCH v5 5/7] remote-mediawiki: support fetching from (Main) namespace Antoine Beaupré
2017-11-07 16:07 ` [PATCH v5 6/7] remote-mediawiki: process namespaces in order Antoine Beaupré
2017-11-07 16:07 ` [PATCH v5 7/7] remote-mediawiki: show progress while fetching namespaces Antoine Beaupré
2017-11-08 2:07 ` [PATCH v5 0/7] namespace support Junio C Hamano
2017-10-30 10:43 ` [PATCH 1/4] remote-mediawiki: add " Matthieu Moy
2017-10-29 16:08 ` [PATCH 2/4] remote-mediawiki: allow fetching namespaces with spaces Antoine Beaupré
2017-10-29 16:08 ` [PATCH 3/4] remote-mediawiki: show known namespace choices on failure Antoine Beaupré
2017-10-29 17:34 ` Eric Sunshine
2017-10-29 18:31 ` Antoine Beaupré
2017-11-04 10:57 ` Thomas Adam
2017-10-29 16:08 ` [PATCH 4/4] remote-mediawiki: allow using (Main) as a namespace and skip special namespaces Antoine Beaupré
2017-10-29 19:49 ` Eric Sunshine
2017-10-30 2:11 ` Antoine Beaupré
2017-10-30 3:49 ` Eric Sunshine
2017-10-30 2:43 ` Antoine Beaupré
2017-10-30 3:52 ` Eric Sunshine
2017-10-30 12:17 ` Antoine Beaupré
2017-10-30 10:40 ` [PATCH 0/4] WIP: git-remote-media wiki namespace support Matthieu Moy
2017-10-30 12:20 ` Antoine Beaupré
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a809959p.fsf@curie.anarc.at \
--to=anarcat@debian.org \
--cc=git@vger.kernel.org \
--cc=kevin@ki-ai.org \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).