git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Johannes Sixt <j6t@kdbg.org>
To: Stephen Boyd <sboyd@kernel.org>
Cc: git@vger.kernel.org, Adrian Johnson <ajohnson@redneon.com>,
	William Duclot <william.duclot@ensimag.grenoble-inp.fr>,
	Matthieu Moy <Matthieu.Moy@imag.fr>,
	devicetree@vger.kernel.org, Alban Gruin <alban.gruin@gmail.com>,
	Junio C Hamano <gitster@pobox.com>,
	Rob Herring <robh+dt@kernel.org>,
	Frank Rowand <frowand.list@gmail.com>
Subject: Re: [PATCH v2] userdiff: Add a builtin pattern for dts files
Date: Mon, 19 Aug 2019 23:35:39 +0200	[thread overview]
Message-ID: <806dbf7a-0488-6dde-70b9-a62cc5dca23e@kdbg.org> (raw)
In-Reply-To: <20190819204451.522D422CEB@mail.kernel.org>

Am 19.08.19 um 22:44 schrieb Stephen Boyd:
> Quoting Johannes Sixt (2019-08-19 11:40:47)
>> Am 17.08.19 um 00:56 schrieb Stephen Boyd:
>>> diff --git a/t/t4018/dts-labels b/t/t4018/dts-labels
>>> new file mode 100644
>>> index 000000000000..27cd4921cfb6
>>> --- /dev/null
>>> +++ b/t/t4018/dts-labels
>>> @@ -0,0 +1,8 @@
>>> +/ {
>>> +     label_1: node1@ff00 {
>>> +             label2: RIGHT {
>>> +                     vendor,some-property;
>>> +                     ChangeMe = <0x45-30>;
>>
>> In these tests, it would be worthwhile to leave another (possibly blank)
>> line before the ChangeMe line in order to demonstrate that lines
>> beginning with a word, such as the 'vendor,some-property;' line, are
>> _not_ picked up when they are not in the hunk context.
> 
> Sure. I can add a blank line. Did you want it on all the tests or just
> some of them?

Some of them. We should have cases that show that
"vendor,some-property;" and "prop-erty = value;" are not picked up.

-- Hannes

      reply	other threads:[~2019-08-19 21:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-16 22:56 [PATCH v2] userdiff: Add a builtin pattern for dts files Stephen Boyd
2019-08-17  1:48 ` Frank Rowand
2019-08-17 15:18 ` Alban Gruin
2019-08-19 18:40 ` Johannes Sixt
2019-08-19 20:44   ` Stephen Boyd
2019-08-19 21:35     ` Johannes Sixt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=806dbf7a-0488-6dde-70b9-a62cc5dca23e@kdbg.org \
    --to=j6t@kdbg.org \
    --cc=Matthieu.Moy@imag.fr \
    --cc=ajohnson@redneon.com \
    --cc=alban.gruin@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=william.duclot@ensimag.grenoble-inp.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).