From: Junio C Hamano <gitster@pobox.com>
To: Brian Gernhardt <brian@gernhardtsoftware.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH v3 3/3] INSTALL: Describe dependency knobs from Makefile
Date: Thu, 10 Sep 2009 11:56:39 -0700 [thread overview]
Message-ID: <7v7hw6aas8.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1252591928-2278-1-git-send-email-brian@gernhardtsoftware.com> (Brian Gernhardt's message of "Thu\, 10 Sep 2009 10\:12\:08 -0400")
Brian Gernhardt <brian@gernhardtsoftware.com> writes:
> We said that some of our dependencies were optional, but didn't say
> how to turn them off. Add information for that and mention where to
> save the options close to the top of the file.
>
> Also, standardize on both using quotes for the names of the dependencies
> and tabs for indentation of the list.
>
> Signed-off-by: Brian Gernhardt <brian@gernhardtsoftware.com>
> ---
>
> Junio C Hamano <gitster@pobox.com> wrote:
> > I did not like calling "make variables" "options", and also it was unclear
> > what good these "options" are for. How about...
>
> Sounds good. Would have sent this out yesterday, but I ran out of tuits.
>
> INSTALL | 38 ++++++++++++++++++++++++--------------
> 1 files changed, 24 insertions(+), 14 deletions(-)
>
> diff --git a/INSTALL b/INSTALL
> index 7ab2580..69c97b2 100644
> --- a/INSTALL
> +++ b/INSTALL
> @@ -13,6 +13,10 @@ that uses $prefix, the built results have some paths encoded,
> which are derived from $prefix, so "make all; make prefix=/usr
> install" would not work.
>
> +There are many options that can be configured in the makefile using either
> +command line defines or a config.mak file. These options are documented at
> +the beginning of the Makefile.
Sorry, but the description still speaks of options and does not say what
good they are. Sent a wrong patch?
next prev parent reply other threads:[~2009-09-10 18:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-09 1:50 [PATCH v2 0/3] INSTALL updates Brian Gernhardt
2009-09-09 1:50 ` [PATCH v2 1/3] INSTALL: Update description of our SHA-1 code Brian Gernhardt
2009-09-09 1:51 ` [PATCH v2 2/3] INSTALL: Reorder dependencies, split shell and Perl Brian Gernhardt
2009-09-09 6:01 ` Junio C Hamano
2009-09-09 1:51 ` [PATCH v2 3/3] INSTALL: Describe dependency knobs from Makefile Brian Gernhardt
2009-09-09 6:16 ` Junio C Hamano
2009-09-10 14:12 ` [PATCH v3 " Brian Gernhardt
2009-09-10 18:56 ` Junio C Hamano [this message]
2009-09-10 20:28 ` Brian Gernhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v7hw6aas8.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=brian@gernhardtsoftware.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).