* Do not barf on too long action description
[not found] ` <20070428002638.GF18276@pasky.or.cz>
@ 2007-04-28 7:15 ` Junio C Hamano
0 siblings, 0 replies; only message in thread
From: Junio C Hamano @ 2007-04-28 7:15 UTC (permalink / raw
To: git; +Cc: Petr Baudis
Reflog message is primarily about easier identification, and
leaving truncated entry is much better than dying.
Signed-off-by: Junio C Hamano <junkio@cox.net>
---
builtin-fetch--tool.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/builtin-fetch--tool.c b/builtin-fetch--tool.c
index 3145c01..1b04881 100644
--- a/builtin-fetch--tool.c
+++ b/builtin-fetch--tool.c
@@ -42,9 +42,7 @@ static int update_ref(const char *action,
if (!rla)
rla = "(reflog update)";
- len = snprintf(msg, sizeof(msg), "%s: %s", rla, action);
- if (sizeof(msg) <= len)
- die("insanely long action");
+ snprintf(msg, sizeof(msg), "%s: %s", rla, action);
lock = lock_any_ref_for_update(refname, oldval);
if (!lock)
return 1;
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2007-04-28 7:15 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20070427203043.GD18276@pasky.or.cz>
[not found] ` <7vfy6lmp0y.fsf@assigned-by-dhcp.cox.net>
[not found] ` <20070427235952.GE18276@pasky.or.cz>
[not found] ` <7vy7kdl5jm.fsf@assigned-by-dhcp.cox.net>
[not found] ` <20070428002638.GF18276@pasky.or.cz>
2007-04-28 7:15 ` Do not barf on too long action description Junio C Hamano
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).