From: Dragan Simic <dsimic@manjaro.org>
To: prpr 19xx <prpr19xx@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Warning message in remote.c when compiling
Date: Sat, 06 Apr 2024 18:12:34 +0200 [thread overview]
Message-ID: <7f0da057773d39add4ede71667e9ff70@manjaro.org> (raw)
In-Reply-To: <CAA1Aqdvj6Eyp9jGaAxTf8p0Eh_rCPydOpin3D5QYHy8sqOoOsw@mail.gmail.com>
Hello,
On 2024-04-06 16:21, prpr 19xx wrote:
> I get this warning message when compiling remote.c:
>
> ...
> CC remote.o
> remote.c:596: warning: 'remotes_remote_get' declared inline after being
> called
> remote.c:596: warning: previous declaration of 'remotes_remote_get' was
> here
> CC replace-object.o
> ...
Could you, please, provide more details about your environment,
i.e. the operating system and compiler?
> This is from the "master" branch, but it's the same on "next". It's
> easily fixed with this patch:
>
> diff --git a/remote.c b/remote.c
> index 2b650b8..347f504 100644
> --- a/remote.c
> +++ b/remote.c
> @@ -592,7 +592,7 @@ const char *pushremote_for_branch(struct branch
> *branch, int *explicit)
> branch, explicit);
> }
>
> -static struct remote *remotes_remote_get(struct remote_state
> *remote_state,
> +static inline struct remote *remotes_remote_get(struct remote_state
> *remote_state,
> const char *name);
>
> const char *remote_ref_for_branch(struct branch *branch, int for_push)
>
> Thanks.
next prev parent reply other threads:[~2024-04-06 16:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-06 14:21 Warning message in remote.c when compiling prpr 19xx
2024-04-06 16:12 ` Dragan Simic [this message]
2024-04-07 1:38 ` Jeff King
2024-04-07 5:10 ` Dragan Simic
2024-04-07 5:40 ` Junio C Hamano
2024-04-07 16:47 ` prpr 19xx
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f0da057773d39add4ede71667e9ff70@manjaro.org \
--to=dsimic@manjaro.org \
--cc=git@vger.kernel.org \
--cc=prpr19xx@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).