From: "Philip Oakley" <philipoakley@iee.org>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Philipp Gortan" <philipp@gortan.org>
Cc: "Git Mailing List" <git@vger.kernel.org>,
"Pat Thoyts" <patthoyts@users.sourceforge.net>
Subject: Re: git-gui ignores core.hooksPath
Date: Sat, 3 Jun 2017 00:00:40 +0100 [thread overview]
Message-ID: <7B6DC5C9C2354BD9BB08DD84FF6628D1@PhilipOakley> (raw)
In-Reply-To: CACBZZX6H4wxQ7hrO1Y1u6Qyr5gpK9GeCxpv-x2q3Eq2WCbkK8Q@mail.gmail.com
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
> On Fri, Jun 2, 2017 at 3:41 PM, Philipp Gortan <philipp@gortan.org> wrote:
>> Hi git devs,
>>
>> First off, thanks for your awesome work!
>>
>> I've been unhappy for quite a while that I had to configure the hooks
>> manually for each of my repos - until I found out recently that there is
>> the core.hooksPath config variable that (when set globally) allows me to
>> specify a hooks directory to be used for all my repositories.
>>
>> Now I was happy - for a few minutes, until I tested this feature in
>> git-gui, and realized that it doesn't work there.
>>
>> This seems to be caused by "proc githook_read", which says "set pchook
>> [gitdir hooks $hook_name]" instead of querying "git config
>> core.hooksPath" first - cf
>> https://github.com/git/git/blob/2cc2e70264e0fcba04f9ef791d144bbc8b501206/git-gui/git-gui.sh#L627
>>
>> Would be great if this could get fixed...
>
> Hi. I added core.hooksPath, glad to see it's useful to other people.
>
> This indeed is something that should be fixed, but git-gui development
> is managed outside of git.git, it's just occasionally pulled in. I'm
> not what the best place to contact is, but I've CC'd
> Philip Oakley who's been making recent commits to git-gui.git at
> http://repo.or.cz/git-gui.git/
The proper maintainer for the git-gui is Pat Thoyts (cc'd) who now has a
repo at https://github.com/patthoyts/git-gui where Pull requests can be
made, with patches posted here initially for wider review.
I'm just another contributor, but I have managed (with a bit of help from
google and formative years using FORTH;-) to get a few git-gui patches
tested and incorporated. tcl/tk isn't that hard, its just interpreted
code.., the main part, for me, was working out how to ru the code in the
Git-for-Windows SDK environment (with help).
--
Philip
next prev parent reply other threads:[~2017-06-02 22:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-02 13:41 git-gui ignores core.hooksPath Philipp Gortan
2017-06-02 14:21 ` Samuel Lijin
2017-06-02 16:38 ` Ævar Arnfjörð Bjarmason
2017-06-02 20:23 ` [PATCH] respect core.hooksPath, falling back to .git/hooks Philipp Gortan
2017-06-02 20:39 ` Philipp Gortan
2017-06-14 13:24 ` Johannes Schindelin
2017-06-02 23:00 ` Philip Oakley [this message]
2017-06-02 23:21 ` git-gui ignores core.hooksPath Philipp Gortan
2017-06-14 13:15 ` Johannes Schindelin
2017-06-14 13:25 ` Philipp Gortan
2018-04-10 15:00 ` Chris Maes
2018-04-10 22:06 ` Johannes Schindelin
2018-04-10 22:50 ` Junio C Hamano
2018-04-10 23:31 ` Ævar Arnfjörð Bjarmason
2018-04-11 0:44 ` Junio C Hamano
2018-06-05 5:48 ` Bert Wesarg
2018-06-11 21:58 ` Stefan Beller
2018-06-12 6:09 ` Johannes Sixt
2018-07-10 12:08 ` Johannes Schindelin
2018-07-10 15:18 ` Philip Oakley
-- strict thread matches above, loose matches on Subject: below --
2017-02-04 17:14 git-gui ignores core.hookspath matthias.serfling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7B6DC5C9C2354BD9BB08DD84FF6628D1@PhilipOakley \
--to=philipoakley@iee.org \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=patthoyts@users.sourceforge.net \
--cc=philipp@gortan.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).