From: Lars Schneider <larsxschneider@gmail.com>
To: "Torsten Bögershausen" <tboegi@web.de>
Cc: GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [RFC] OS X El Capitan + Xcode ships without SSL header?!
Date: Tue, 1 Dec 2015 10:04:02 +0100 [thread overview]
Message-ID: <7AD88D08-04E7-485E-9465-692F3043C445@gmail.com> (raw)
In-Reply-To: <565B3036.8000604@web.de>
On 29 Nov 2015, at 18:04, Torsten Bögershausen <tboegi@web.de> wrote:
> On 21/11/15 19:58, Lars Schneider wrote:
>> Hi,
>>
>> I cannot build Git on a clean machine with OS X El Capitan 10.11, Xcode 7.1.1 and Xcode command line tools because of missing OpenSSL headers.
>>
>> It looks like as there are no OpenSSL headers at all. I only found this weird non working version:
>> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift-migrator/sdk/MacOSX.sdk/usr/include/openssl/ssl.h
>>
>> I installed OpenSSL with brew, added the include path and it works.
>>
>> Can anyone confirm?
>>
>> Thanks,
>> Lars
>>
> (Does it make sense that you send a patch which auto-detects brew similar to fink or mac ports?)
I think that would make sense. I'll look into it if I find some free cycles...
>
> After some proper updating of one test machine I ran into the same problem.
> A possible patch may look like this:
>
>
> commit 5e7c16f3350e8e62bfdb181b0b5da7352945d046
> Author: Torsten Bögershausen <tboegi@web.de>
> Date: Sun Nov 29 17:29:22 2015 +0100
>
> Mac OS X 10.11: set NO_OPENSSL
>
> There is no openssl/ directory any more in Mac OS X 10.11,
> openssl is depracated since Mac OS X 10.7
>
> Set NO_OPENSSL to YesPlease as default under Mac OS X, and make it
> possible to override this and use openssl by defining DARWIN_OPENSSL
>
> diff --git a/config.mak.uname b/config.mak.uname
> index f34dcaa..a8a8b07 100644
> --- a/config.mak.uname
> +++ b/config.mak.uname
> @@ -105,6 +105,12 @@ ifeq ($(uname_S),Darwin)
> ifeq ($(shell test "`expr "$(uname_R)" : '\([0-9][0-9]*\)\.'`" -ge 11 && echo 1),1)
> HAVE_GETDELIM = YesPlease
> endif
> + # MacOS 10.11 and higher
> + ifeq ($(shell test "`expr "$(uname_R)" : '\([0-9][0-9]*\)\.'`" -ge 15 && echo 1),1)
> + ifndef DARWIN_OPENSSL
> + NO_OPENSSL = YesPlease
> + endif
> + endif
That would propably do it. However, what are the ramifications here? Does this affect `git clone` over HTTPS or even SSH? Sorry if this question sounds stupid but I am not too familiar with these systems. If there are indeed these severe ramifications then I would probably print a little tutorial how to install OpenSSL via brew.
Maybe one could use Apple's TLS implementation [1] on OS X alternatively. However, I don't know how different the APIs are and the resulting "ifdefs" are probably undesired.
Cheers,
Lars
[1] https://developer.apple.com/library/mac/documentation/Security/Reference/secureTransportRef/
prev parent reply other threads:[~2015-12-01 9:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-21 18:58 [RFC] OS X El Capitan + Xcode ships without SSL header?! Lars Schneider
2015-11-22 13:12 ` Dair Grant
2015-11-29 17:04 ` Torsten Bögershausen
2015-12-01 9:04 ` Lars Schneider [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7AD88D08-04E7-485E-9465-692F3043C445@gmail.com \
--to=larsxschneider@gmail.com \
--cc=git@vger.kernel.org \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).