From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id AC7211F619 for ; Thu, 12 Mar 2020 04:14:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731078AbgCLEO3 (ORCPT ); Thu, 12 Mar 2020 00:14:29 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:47625 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726534AbgCLEO3 (ORCPT ); Thu, 12 Mar 2020 00:14:29 -0400 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 95494220CA for ; Thu, 12 Mar 2020 00:14:28 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Thu, 12 Mar 2020 00:14:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jramsay.com.au; h=from:to:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s=mesmtp; bh=9J64zS+E3V4LMpdEWB+FInlstW72Xe+IKOfY1zL9tyI=; b=cwAigg3Px10B 9MpktYAHH+rW4BtA4XVipYDj14yOPB0isuzp5jQh+2dafsyH/7PSqK2tXMWhMkln mGhFEYyxsMpnsbaudkpHPLCZymJvkVpc0AuvdMIgg2CUX3ZJW1iTgLfWfYy+YZ0W I99/vozcdxLonXXgF/RFHKD8xf1jIeE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=9J64zS+E3V4LMpdEWB+FInlstW72Xe+IKOfY1zL9t yI=; b=ZhaRqZTZ4q0Mppze+S9c85VJJGzU/BjViuhea6MHbej3Y+qth4FbrnXjh DInpeoYfn8vnxpf+kKdM3kLL7urap7EOAX+dizesB3GYNScoMdPT3ZC/KhgFwzJg 8jNu6bjvxi9fu8QsVZGdRYRM/xU5z+7pkx6Y87LjiNc08vIzjCDwEVhRH4YwhQqC cWOQZ+T1RxZsx01WyZNxc41EktgYAtOa3D2vUfk+ujkRpzQZUt0XUXkX4u7mrOz8 Iiz6WtMy7ybSLhCjjOlhHFsknGfI6fMROoh3jJF7wJXU2UBEv7tCGNf7Bfv5yuwu vv2B7FYpVNsGGIK0EwpXmL63bHdOQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedruddvgedgkedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffokfgjfhggtgfgsehtke hmtdertdejnecuhfhrohhmpedflfgrmhgvshcutfgrmhhsrgihfdcuoehjrghmvghssehj rhgrmhhsrgihrdgtohhmrdgruheqnecukfhppeduvddurddvtddtrdeirdduuddtnecuve hluhhsthgvrhfuihiivgepudenucfrrghrrghmpehmrghilhhfrhhomhepjhgrmhgvshes jhhrrghmshgrhidrtghomhdrrghu X-ME-Proxy: Received: from [192.168.1.38] (121-200-6-110.79c806.syd.nbn.aussiebb.net [121.200.6.110]) by mail.messagingengine.com (Postfix) with ESMTPA id C3EA030611FB for ; Thu, 12 Mar 2020 00:14:27 -0400 (EDT) From: "James Ramsay" To: git@vger.kernel.org Subject: [TOPIC 16/17] =?utf-8?q?=E2=80=9CI?= want a =?utf-8?q?reviewer=E2=80=9D?= Date: Thu, 12 Mar 2020 15:14:25 +1100 X-Mailer: MailMate (1.13.1r5671) Message-ID: <6DAC1E49-9CA0-4074-867E-F22CD26C9FEB@jramsay.com.au> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org 1. Jonathan N: An experience some folks have is, sending a patch and hearing nothing. That must mean patch is awesome. But then realize I need to do something to get a review. In Git, people like Peff are good about responding to newcomers. As an author it can be hard to excite people enough to review your patch. Relatedly, you might get a review, but it doesn’t give you the feedback you wanted. As a reviewer, you want to help people to grow and make progress quickly, but it might not be easy to identify patches where this will be possible. 2. Emily: A few months ago we started doing code review book club. Git devel IRC, and mailing list, could we be more public about these? I queue my patch to list of things that have been idle and needs a review, then a bot pops something off the list to increase attention for people to review? 3. Jonathan Tan: during book club we discuss and review together. Everyone can benefit from review experience and expertise. Emily is hoping for similar knowledge transfer in the IRC channel. 4. Brian: general case that patches don’t get lost. There is the git context script, but I am now a reviewer because I have touched everything for SHA256. But we are losing patches and bug reports because things get missed. What tool would we use? How would we do it? 5. Jonathan N: patchwork exists, need to learn how to use it :) 6. Peff: this is all possible on the mailing list. I see things that look interesting, and have a to do folder. If someone replies, I’ll take it off the list. Once a week go through all the items. I like the book club idea, instead of it being ad hoc, or by me, a group of a few people review the list in the queue. You might want to use a separate tool, like IRC, but it would be good to have it bring it back to the mailing list as a summary. Public inbox could be better, but someone needs to write it. Maybe nerd snipe Eric? 7. Stolee: not just about doing reviews, but training reviewers.