git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Ilya Kantor <iliakan@gmail.com>
To: phillip.wood@dunelm.org.uk
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	git@vger.kernel.org, "Junio C Hamano" <junio@pobox.com>,
	"Johannes Schindelin" <Johannes.Schindelin@gmx.de>
Subject: Re: CMakeLists.txt from contrib/buildsystems fails to build on Mac
Date: Wed, 8 Feb 2023 15:34:18 +0100	[thread overview]
Message-ID: <68C6062A-7833-48F2-8F44-3BB129E5E9E5@gmail.com> (raw)
In-Reply-To: <a120ea47-722d-2bb0-9c49-294a850af6af@dunelm.org.uk>

Hi,

Thank you for the responses.

Yes, I saw the discussion, but couldn't figure out the final outcome.

Indeed, I'd suggest to remove the mention of any other platforms if it's windows-only.

And if it's windows-only, then it makes sense to move it to git-for-windows, at least for a bird's-eye view.

Kind regards,
Ilya Kantor

> On 8 Feb 2023, at 15:31, Phillip Wood <phillip.wood123@gmail.com> wrote:
> 
> Hi Ævar
> 
> On 08/02/2023 11:57, Ævar Arnfjörð Bjarmason wrote:
>> Or rather, that GFW would be fixing it up, but then I don't see why it
>> should be in git.git, which as your message shows just leads to
>> confusion about why this component is in git.git's tree.
> 
> I think Ilya's message shows we need to update the instructions in CMakeLists.txt to make it clear it is Windows only.
> 
> Best Wishes
> 
> Phillip


  reply	other threads:[~2023-02-08 14:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-08 11:45 CMakeLists.txt from contrib/buildsystems fails to build on Mac Ilya Kantor
2023-02-08 11:57 ` Ævar Arnfjörð Bjarmason
2023-02-08 14:31   ` Phillip Wood
2023-02-08 14:34     ` Ilya Kantor [this message]
2023-02-08 16:53     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=68C6062A-7833-48F2-8F44-3BB129E5E9E5@gmail.com \
    --to=iliakan@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=junio@pobox.com \
    --cc=phillip.wood@dunelm.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).