From: "Torsten Bögershausen" <tboegi@web.de>
To: Beat Bolli <dev+git@drbeat.li>, git@vger.kernel.org
Subject: Re: [PATCH 1/3] update_unicode.sh: update the uniset repo if it exists
Date: Mon, 12 Dec 2016 06:53:16 +0100 [thread overview]
Message-ID: <64bc846c-0304-dd7b-73bf-a6c3a4135381@web.de> (raw)
In-Reply-To: <1481499265-18361-1-git-send-email-dev+git@drbeat.li>
On 2016-12-12 00:34, Beat Bolli wrote:
> We need to track the new commits in uniset, otherwise their and our code
> get out of sync.
>
> Signed-off-by: Beat Bolli <dev+git@drbeat.li>
> ---
>
> Junio, these go on top of my bb/unicode-9.0 branch, please.
>
> Thanks!
>
> update_unicode.sh | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/update_unicode.sh b/update_unicode.sh
> index 4c1ec8d..9ca7d8b 100755
> --- a/update_unicode.sh
> +++ b/update_unicode.sh
> @@ -14,6 +14,11 @@ fi &&
> http://www.unicode.org/Public/UCD/latest/ucd/EastAsianWidth.txt &&
> if ! test -d uniset; then
> git clone https://github.com/depp/uniset.git
> + else
> + (
> + cd uniset &&
> + git pull
If upstream has accepted your patches, that's nice.
Minor question, especially to the next commit:
Should we make sure to checkout the exact version, which has been tested?
In this case cb97792880625e24a9f581412d03659091a0e54f
And this is for both a fresh clone and the git pull
needs to be replaced by
git fetch && git checkout cb97792880625e24a9f581412d03659091a0e54f
(Which of course is a shell variable
next prev parent reply other threads:[~2016-12-12 5:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-11 23:34 [PATCH 1/3] update_unicode.sh: update the uniset repo if it exists Beat Bolli
2016-12-11 23:34 ` [PATCH 2/3] update_unicode.sh: remove the plane filters Beat Bolli
2016-12-11 23:34 ` [PATCH 3/3] update_unicode.sh: restore hexadecimal output Beat Bolli
2016-12-12 5:53 ` Torsten Bögershausen [this message]
2016-12-12 8:54 ` [PATCH 1/3] update_unicode.sh: update the uniset repo if it exists Beat Bolli
2016-12-12 18:12 ` Torsten Bögershausen
2016-12-12 18:33 ` Junio C Hamano
2016-12-12 23:50 ` Beat Bolli
2016-12-13 6:16 ` Torsten Bögershausen
2016-12-13 6:42 ` Junio C Hamano
2016-12-12 19:24 ` Beat Bolli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64bc846c-0304-dd7b-73bf-a6c3a4135381@web.de \
--to=tboegi@web.de \
--cc=dev+git@drbeat.li \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).