From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.6 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id E3C331F4DA for ; Tue, 4 Oct 2022 16:20:50 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="U2ccTE6G"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229988AbiJDQUc (ORCPT ); Tue, 4 Oct 2022 12:20:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229755AbiJDQUQ (ORCPT ); Tue, 4 Oct 2022 12:20:16 -0400 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B910402E3 for ; Tue, 4 Oct 2022 09:20:15 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id o5so9255220wms.1 for ; Tue, 04 Oct 2022 09:20:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date; bh=o2ispt3iRKRIfJEw6xvAmp2DiIRviuvQfEr6Qu/yjNE=; b=U2ccTE6GyFkgXKbtp7CL1LpzT80/2BkEmulvU2abuRWhR5Y38d9JnBSz2eiCrFM3v+ iS1dQJAqefgN5MgzXlPnoPLkZ/g1guhtvmsSDYu1NkCj3ZZ4L5i349CUEpkdOZoMNL89 AUq4WDAklxUZuvE1aCXjho86S92ffQ4Et2xFSj+zfvvM7tfhSsSZZAr1oJgE0zSbCC+w e9aVJtbthWYekqXEfX9+WsG1jgWi6yq4xTIv2SILIBBGx5SWmvip3QT0lLglKQqMHIwH LZw1R5BRygkt4vg1s8OwR8qEunDNn4wInyIuRgqrawPQ4qhHXH7xbeobnw/EGQMy6IQO cAhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date; bh=o2ispt3iRKRIfJEw6xvAmp2DiIRviuvQfEr6Qu/yjNE=; b=wyJFwM+7asYQjnSpuyLEl7SErgJkgIo+4vL9IEUh6yvwM2WU7TE7lkXMDCgpNCRqa7 n+QIUdbcskjQTAGRMuzBm1tkasKu6T76aDW6fkhzBuMLktLfo3KJQYL9QoxFvO7ree9a RPI5C6GZ4JGhn0Fka9uh1yXDnqx0AHshtdspTGrTVKubrIfy+ahM8CSjk2SRCVONlVI2 VT1vFEAssKRAsbt6ZGyDae/MRlB3wsGWbl0u+kwg60ZSlvTIJhExetpOcqbgnoAHaWgQ m+3BrpBxqrJAS7KCUoP3Uk8nhN/KL4KAiEheaNrfwV6eY7IAzAzql0qhtucPAhgErYwN ez6A== X-Gm-Message-State: ACrzQf3/NRJzZ7Z/DNs/J+5JDhuxUst2RttRlBtwvk7l96pe4U1YzomI Z3OMxWzoXhXzpACH96pyptlT8yftAdU= X-Google-Smtp-Source: AMsMyM7VKH6kidoJR2/WmXD2c3f+VNVdQ7CUH08XVAdUYwC9Sp3XzVhf8eZ4Ol1rqiba7V+rPVjuHA== X-Received: by 2002:a05:600c:3d8e:b0:3b4:a61c:52cc with SMTP id bi14-20020a05600c3d8e00b003b4a61c52ccmr403946wmb.7.1664900413678; Tue, 04 Oct 2022 09:20:13 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id i7-20020a05600011c700b0021e51c039c5sm7791346wrx.80.2022.10.04.09.20.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Oct 2022 09:20:13 -0700 (PDT) Message-Id: <6492b6d2b989e08bb539fff3ffe5bdf50fa0a195.1664900407.git.gitgitgadget@gmail.com> In-Reply-To: References: From: "Jeff Hostetler via GitGitGadget" Date: Tue, 04 Oct 2022 16:20:04 +0000 Subject: [PATCH 6/9] trace2: convert ctx.thread_name to flex array Fcc: Sent Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit MIME-Version: 1.0 To: git@vger.kernel.org Cc: Jeff Hostetler , Jeff Hostetler Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org From: Jeff Hostetler Convert the `tr2tls_thread_ctx.thread_name` field from a `strbuf` to a "flex array" at the end of the context structure. The `thread_name` field is a constant string that is constructed when the context is created. Using a (non-const) `strbuf` structure for it caused some confusion in the past because it implied that someone could rename a thread after it was created. That usage was not intended. Changing it to a "flex array" will hopefully make the intent more clear. Also, move the maximum thread_name truncation to tr2_tgt_perf.c because it is the only target that needs to worry about output column alignment. Signed-off-by: Jeff Hostetler --- trace2/tr2_tgt_event.c | 2 +- trace2/tr2_tgt_perf.c | 8 ++++++-- trace2/tr2_tls.c | 25 +++++++++++++------------ trace2/tr2_tls.h | 9 +-------- 4 files changed, 21 insertions(+), 23 deletions(-) diff --git a/trace2/tr2_tgt_event.c b/trace2/tr2_tgt_event.c index 37a3163be12..52f9356c695 100644 --- a/trace2/tr2_tgt_event.c +++ b/trace2/tr2_tgt_event.c @@ -90,7 +90,7 @@ static void event_fmt_prepare(const char *event_name, const char *file, jw_object_string(jw, "event", event_name); jw_object_string(jw, "sid", tr2_sid_get()); - jw_object_string(jw, "thread", ctx->thread_name.buf); + jw_object_string(jw, "thread", ctx->thread_name); /* * In brief mode, only emit