From: Cornelius Weig <cornelius.weig@tngtech.com>
To: Philip Oakley <philipoakley@iee.org>, Junio C Hamano <gitster@pobox.com>
Cc: Stefan Beller <sbeller@google.com>, Johannes Sixt <j6t@kdbg.org>,
bitte.keine.werbung.einwerfen@googlemail.com,
git@vger.kernel.org
Subject: Re: SubmittingPatches: drop temporal reference for PGP signing
Date: Fri, 27 Jan 2017 11:49:26 +0100 [thread overview]
Message-ID: <60e9abdf-cc37-33d8-e7eb-8a3370ffe1cc@tngtech.com> (raw)
In-Reply-To: <4B89512D54614F09817EA9901A8B625D@PhilipOakley>
On 01/26/2017 09:58 PM, Philip Oakley wrote:
> From: "Junio C Hamano" <gitster@pobox.com>
>> Cornelius Weig <cornelius.weig@tngtech.com> writes:
>>
>>> How about something along these lines? Does the forward reference
>>> break the main line of thought too severly?
>>
>> I find it a bit distracting for those who know PGP signing has
>> nothing to do with signing off your patch, but I think that is OK
>> because they are not the primary target audience of this part of the
>> document.
>
> Agreed. I this case the target audience was those weren't aware of that.
Yes, maybe the forward reference does give a wrong hint about a
connection between sign-off and pgp-signing. However, I would still vote
for the following change suggested by sbeller@google.com:
-Do not PGP sign your patch, -at least for now-. Most likely, your (...)
+Do not PGP sign your patch. Most likely, your maintainer or other (...)
>
> Maybe even s/by signing off/by adding your Signed-off-by:/ to be sure
> that the reader knows that it is _their certification_ that is being
> sought. Even if it does double up on the 'your'.
>
I don't think doubling on the 'your' will make the heading clearer. The
main intention of this change is to avoid mixups with pgp-signing and
that would IMHO not improve by that.
Besides, I find the colon in the heading a bit awkward. Is the following
version as expressive as with the colon?
-(5) Sign your work
+(5) Certify your work by adding Signed-off-by
next prev parent reply other threads:[~2017-01-27 10:49 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-22 22:57 [PATCH 0/7] completion bash: add more options and commands bitte.keine.werbung.einwerfen
2017-01-22 22:57 ` [PATCH 1/7] completion: teach options to submodule subcommands bitte.keine.werbung.einwerfen
2017-01-22 22:57 ` [PATCH 2/7] completion: add subcommand completion for rerere bitte.keine.werbung.einwerfen
2017-02-02 0:57 ` SZEDER Gábor
2017-02-02 9:16 ` Cornelius Weig
2017-01-22 22:57 ` [PATCH 3/7] completion: improve bash completion for git-add bitte.keine.werbung.einwerfen
2017-01-22 22:57 ` [PATCH 4/7] completion: teach ls-remote to complete options bitte.keine.werbung.einwerfen
2017-02-02 1:40 ` SZEDER Gábor
2017-02-02 9:40 ` Cornelius Weig
2017-02-02 16:57 ` Junio C Hamano
2017-01-22 22:57 ` [PATCH 5/7] completion: teach replace " bitte.keine.werbung.einwerfen
2017-01-22 22:57 ` [PATCH 6/7] completion: teach remote subcommands option completion bitte.keine.werbung.einwerfen
2017-02-02 1:37 ` SZEDER Gábor
2017-02-02 10:29 ` Cornelius Weig
2017-01-22 22:57 ` [PATCH 7/7] completion: recognize more long-options bitte.keine.werbung.einwerfen
2017-01-24 7:15 ` Johannes Sixt
2017-01-24 8:14 ` Cornelius Weig
2017-01-24 23:24 ` Junio C Hamano
2017-01-24 23:33 ` Cornelius Weig
2017-01-24 23:43 ` Stefan Beller
2017-01-25 0:11 ` Cornelius Weig
2017-01-25 0:21 ` Stefan Beller
2017-01-25 0:43 ` Cornelius Weig
2017-01-25 0:52 ` Re: Stefan Beller
2017-01-25 0:54 ` Re: Linus Torvalds
2017-01-25 1:32 ` Re: Eric Wong
2017-01-25 6:54 ` SubmittingPatches: drop temporal reference for PGP signing Philip Oakley
2017-01-25 22:38 ` Stefan Beller
2017-01-26 13:30 ` Cornelius Weig
2017-01-26 17:57 ` Stefan Beller
2017-01-26 18:18 ` Junio C Hamano
2017-01-26 20:58 ` Philip Oakley
2017-01-27 10:49 ` Cornelius Weig [this message]
2017-01-27 17:43 ` Junio C Hamano
2017-01-27 21:17 ` [PATCH v2 0/7] completion: recognize more long-options cornelius.weig
2017-01-27 21:17 ` [PATCH v2 7/7] " cornelius.weig
2017-01-31 22:17 ` SZEDER Gábor
2017-02-01 16:49 ` Cornelius Weig
2017-02-02 2:00 ` SZEDER Gábor
2017-02-02 10:40 ` Cornelius Weig
2017-01-31 22:42 ` [PATCH 3/7] completion: improve bash completion for git-add SZEDER Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60e9abdf-cc37-33d8-e7eb-8a3370ffe1cc@tngtech.com \
--to=cornelius.weig@tngtech.com \
--cc=bitte.keine.werbung.einwerfen@googlemail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=philipoakley@iee.org \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).