From: Phillip Wood <phillip.wood123@gmail.com>
To: Junio C Hamano <gitster@pobox.com>,
David Bimmler via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, David Bimmler <david.bimmler@isovalent.com>
Subject: Re: [PATCH] sequencer: honor signoff opt in run_git_commit
Date: Thu, 4 Apr 2024 20:22:53 +0100 [thread overview]
Message-ID: <54b91c03-5170-493a-8c0c-def2ac1f804a@gmail.com> (raw)
In-Reply-To: <xmqqr0fl13gh.fsf@gitster.g>
On 04/04/2024 17:45, Junio C Hamano wrote:
> git show -s --format=%B HEAD >actual &&
> test_cmp expect actual
>
> may be a good replacement.
we have test_commit_message to do that these days.
Best Wishes
Phillip
> But having said that, and then after having looked at the existing
> tests in the file, I see that it is littered with the same "do not
> run git on the upstream of the pipe" violation. So let's not worry
> about this one. The whole t3428 script needs to be cleaned up after
> the dust settles.
>
> Thanks.
>
next prev parent reply other threads:[~2024-04-04 19:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-04 9:39 [PATCH] sequencer: honor signoff opt in run_git_commit David Bimmler via GitGitGadget
2024-04-04 16:22 ` Junio C Hamano
2024-04-04 16:45 ` Junio C Hamano
2024-04-04 19:22 ` Phillip Wood [this message]
2024-04-04 19:21 ` Phillip Wood
2024-04-05 11:50 ` David Bimmler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54b91c03-5170-493a-8c0c-def2ac1f804a@gmail.com \
--to=phillip.wood123@gmail.com \
--cc=david.bimmler@isovalent.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).