From: Tanay Abhra <tanayabh@gmail.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: git@vger.kernel.org, Ramkumar Ramachandra <artagnon@gmail.com>,
Karsten Blees <karsten.blees@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
Eric Sunshine <sunshine@sunshineco.com>
Subject: Re: [PATCH 2/2] test-config: Add tests for the config_set API
Date: Wed, 02 Jul 2014 17:34:39 +0530 [thread overview]
Message-ID: <53B3F557.3080001@gmail.com> (raw)
In-Reply-To: <vpqzjgskt1v.fsf@anie.imag.fr>
On 7/2/2014 2:59 PM, Matthieu Moy wrote:
> Tanay Abhra <tanayabh@gmail.com> writes:
>
>> +test_expect_success 'clear default config' '
>> + rm -f .git/config
>> +'
>> +
>> +cat > .git/config << EOF
>
> t/README says:
>
> - Put all code inside test_expect_success and other assertions.
>
> Even code that isn't a test per se, but merely some setup code
> should be inside a test assertion.
>
> Even these cat > would better be in a test_expect_success 'initialize
> config'.
>
> (Not applied everywhere in Git's code essentially because some tests
> were written before the guideline was set and never updated).
Sorry about that. I followed t1300-repo-config.sh which has these mistakes
also.
>> +[core]
>> + penguin = very blue
>> + Movie = BadPhysics
>> + UPPERCASE = true
>> + MixedCase = true
>> + my =
>> + foo
>> + baz = sam
>> +[Cores]
>> + WhatEver = Second
>> +[my "Foo bAr"]
>> + hi = hello
>
> To really stress the "case sensitive middle part" case, you should also
> have other sections like
>
> [my "foo bar"]
> hi = lower-case
> [my "FOO BAR"]
> hi = upper-case
>
> and check that you get the right value for my.*.hi
>
> Similarly, I'd add a [CORE] and a [CoRe] section to check that their
> content is actually merged with [core].
>
Noted.
>> +test_expect_success 'get value for a key with value as an empty string' '
>> + echo "" >expect &&
>> + test-config get_value core.my >actual &&
>> + test_cmp expect actual
>> +'
>> +
>> +test_expect_success 'get value for a key with value as NULL' '
>> + echo "(NULL)" >expect &&
>> + test-config get_value core.foo >actual &&
>> + test_cmp expect actual
>> +'
>> +test_expect_success 'upper case key' '
>
> Keep the style consistent, if you separate tests with a single blank
> line, do it everywhere.
>
>> +cat > expect << EOF
>
> See above, should be in test_expect_success.
>
> Also, >expect, not > expect.
>
> There are other instances.
>
Noted. Again copied t1300-repo-config.sh style for cat.
>> +1
>> +0
>> +1
>> +1
>> +1
>> +EOF
>> +
>> +test_expect_success 'find bool value for the entered key' '
>> + test-config get_bool goat.head >>actual &&
>
> The first one should be a single >, or you should clear actual before
> the test.
>
Noted.
>> +int main(int argc, char **argv)
>> +{
>> + int i, no_of_files;
>> + int ret = 0;
>> + const char *v;
>> + int val;
>> + const struct string_list *strptr;
>> + struct config_set cs = CONFIG_SET_INIT;
>
>
>
>> + if (argc == 3 && !strcmp(argv[1], "get_value")) {
>> + if (!git_config_get_value(argv[2], &v)) {
>> + if (!v)
>> + printf("(NULL)\n");
>> + else
>> + printf("%s\n", v);
>> + return 0;
>> + } else {
>> + printf("Value not found for \"%s\"\n", argv[2]);
>> + return -1;
>> + }
>> + } else if (argc == 3 && !strcmp(argv[1], "get_value_multi")) {
>> + strptr = git_config_get_value_multi(argv[2]);
>> + if (strptr) {
>> + for (i = 0; i < strptr->nr; i++) {
>> + v = strptr->items[i].string;
>> + if (!v)
>> + printf("(NULL)\n");
>> + else
>> + printf("%s\n", v);
>> + }
>> + return 0;
>> + } else {
>> + printf("Value not found for \"%s\"\n", argv[2]);
>> + return -1;
>> + }
>> + } else if (argc == 3 && !strcmp(argv[1], "get_int")) {
>> + if (!git_config_get_int(argv[2], &val)) {
>> + printf("%d\n", val);
>> + return 0;
>> + } else {
>> + printf("Value not found for \"%s\"\n", argv[2]);
>> + return -1;
>> + }
>> + } else if (argc == 3 && !strcmp(argv[1], "get_bool")) {
>> + if (!git_config_get_bool(argv[2], &val)) {
>> + printf("%d\n", val);
>> + return 0;
>> + } else {
>> + printf("Value not found for \"%s\"\n", argv[2]);
>> + return -1;
>> + }
>> + } else if (!strcmp(argv[1], "configset_get_value")) {
>> + no_of_files = git_config_int("unused", argv[2]);
>
> Why ask the user to give a number of files on the command-line. With a
> syntax like
>
> test-config configset_get_value <key> <files>...
>
> you could just use argc to iterate over argv. Here, you trust the user
> to provide the right value, and most likely segfault otherwise (and this
> is not really documented). I know this is only test code, but why not do
> it right anyway ;-).
>
Yup, your way is much better, thanks for the review.
Tanay.
prev parent reply other threads:[~2014-07-02 12:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-02 6:01 [PATCH v4 0/3] git config cache & special querying api utilizing the cache Tanay Abhra
2014-07-02 6:01 ` [PATCH v4 1/2] add `config_set` API for caching config files Tanay Abhra
2014-07-02 9:14 ` Matthieu Moy
2014-07-02 11:58 ` Tanay Abhra
2014-07-02 14:32 ` Matthieu Moy
2014-07-02 17:09 ` Junio C Hamano
2014-07-04 4:58 ` Tanay Abhra
2014-07-04 9:17 ` Matthieu Moy
2014-07-04 9:25 ` Tanay Abhra
2014-07-04 9:43 ` Matthieu Moy
2014-07-07 17:02 ` Junio C Hamano
2014-07-02 17:00 ` Junio C Hamano
2014-07-02 17:09 ` Matthieu Moy
2014-07-03 17:05 ` Tanay Abhra
2014-07-02 6:01 ` [PATCH 2/2] test-config: Add tests for the config_set API Tanay Abhra
2014-07-02 9:29 ` Matthieu Moy
2014-07-02 12:04 ` Tanay Abhra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B3F557.3080001@gmail.com \
--to=tanayabh@gmail.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=karsten.blees@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).