From mboxrd@z Thu Jan 1 00:00:00 1970 From: Philip Oakley Subject: Re: [PATCH 05/13] Help.c: add list_common_guides_help() function Date: Mon, 25 Feb 2013 23:43:43 +0000 Message-ID: <512BF72F.9030404@iee.org> References: <1361660761-1932-1-git-send-email-philipoakley@iee.org> <1361660761-1932-6-git-send-email-philipoakley@iee.org> <7vmwuu5bm1.fsf@alter.siamese.dyndns.org> <4AEE9909C70D4810A228A367FB888AF4@PhilipOakley> <7vk3px3qzp.fsf@alter.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: GitList To: Junio C Hamano X-From: git-owner@vger.kernel.org Tue Feb 26 00:44:15 2013 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UA7iO-00037Z-8I for gcvg-git-2@plane.gmane.org; Tue, 26 Feb 2013 00:44:12 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759921Ab3BYXnq (ORCPT ); Mon, 25 Feb 2013 18:43:46 -0500 Received: from out1.ip01ir2.opaltelecom.net ([62.24.128.237]:55969 "EHLO out1.ip01ir2.opaltelecom.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759631Ab3BYXnq (ORCPT ); Mon, 25 Feb 2013 18:43:46 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApMBAIP2K1FZ8rke/2dsb2JhbAANOMFcgRyDEgEBAQEDOEABEAsUAQECCRYPCQMCAQIBRQYNAQUCAQG0dZM3jw4HY4JdA6AeiX4N X-IronPort-AV: E=Sophos;i="4.84,736,1355097600"; d="scan'208";a="420336205" Received: from host-89-242-185-30.as13285.net (HELO [192.168.0.7]) ([89.242.185.30]) by out1.ip01ir2.opaltelecom.net with ESMTP; 25 Feb 2013 23:43:44 +0000 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 In-Reply-To: <7vk3px3qzp.fsf@alter.siamese.dyndns.org> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On 25/02/13 05:24, Junio C Hamano wrote: > "Philip Oakley" writes: > >> From: "Junio C Hamano" >> Sent: Sunday, February 24, 2013 9:01 AM >>> Philip Oakley writes: >>> >>>> diff --git a/common-guides.h b/common-guides.h >>>> new file mode 100644 >>>> index 0000000..a8ad8d1 >>>> --- /dev/null >>>> +++ b/common-guides.h >>>> @@ -0,0 +1,12 @@ >>>> +/* Automatically generated by ./generate-guidelist.sh */ >>>> +/* re-use struct cmdname_help in common-commands.h */ >>> >>> Huh? >> The first comment line fortells of patch 6 which can generate this .h >> file. > > The Huh? was about that one, not about reuse. I do not want to see > a build artifact kept in the history without a good reason. > I'd copied it from generate-cmdlist.sh which is a common-cmd.h dependency and was introduced by commit a87cd02ce02e97083eb76eb8b9bfeb2e46800fd7 Author: Fredrik Kuivinen Date: Thu Mar 9 17:24:19 2006 +0100 Nicer output from 'git' [jc: with suggestions by Jan-Benedict Glaw] Signed-off-by: Fredrik Kuivinen Signed-off-by: Junio C Hamano The reason in this (my) case, as then, is that it states how the file is generated so that it can be regenerated later. If the patches are successful then I'd want the generate-guidelist and generate-cmdlist to be joined together as an integral part of generating the help system data. Mind you each review point turns over another stone that needs to be considered, such as the Makefile link of common-commands.h and similarly for the Documentation/Makefile - I'm thinking of the issues around 'gitk' and its ilk which isn't a common command (because it has no hyphen) yet is in the command list, so can be confused with the support documentation, however I don't mark it as a common guide, so that's OK. ('git help k' does offer the gitk man page ;-) I'll tidy up the series over the next few days to include the points so far Philip