From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Philip Oakley" Subject: Re: [PATCH 05/13] Help.c: add list_common_guides_help() function Date: Sun, 24 Feb 2013 21:51:34 -0000 Organization: OPDS Message-ID: <4AEE9909C70D4810A228A367FB888AF4@PhilipOakley> References: <1361660761-1932-1-git-send-email-philipoakley@iee.org> <1361660761-1932-6-git-send-email-philipoakley@iee.org> <7vmwuu5bm1.fsf@alter.siamese.dyndns.org> Reply-To: "Philip Oakley" Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset="iso-8859-1"; reply-type=original Content-Transfer-Encoding: 7bit Cc: "GitList" To: "Junio C Hamano" X-From: git-owner@vger.kernel.org Sun Feb 24 22:52:01 2013 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1U9jUB-0003XC-VA for gcvg-git-2@plane.gmane.org; Sun, 24 Feb 2013 22:51:56 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758190Ab3BXVva (ORCPT ); Sun, 24 Feb 2013 16:51:30 -0500 Received: from out1.ip02ir2.opaltelecom.net ([62.24.128.238]:44300 "EHLO out1.ip02ir2.opaltelecom.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757214Ab3BXVva (ORCPT ); Sun, 24 Feb 2013 16:51:30 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AgMFAEN0KlFZ8rke/2dsb2JhbABFjAu1RYEPF3OCGgUBAQUIAQEuHgEBIQsCAwUCAQMVAQslFAEEGgYHFwYTCAIBAgMBiAa8T44vX4JmYQOIM4VhkgqHBIMH X-IronPort-AV: E=Sophos;i="4.84,730,1355097600"; d="scan'208";a="419658876" Received: from host-89-242-185-30.as13285.net (HELO PhilipOakley) ([89.242.185.30]) by out1.ip02ir2.opaltelecom.net with SMTP; 24 Feb 2013 21:51:28 +0000 X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2900.5931 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: From: "Junio C Hamano" Sent: Sunday, February 24, 2013 9:01 AM > Philip Oakley writes: > >> diff --git a/common-guides.h b/common-guides.h >> new file mode 100644 >> index 0000000..a8ad8d1 >> --- /dev/null >> +++ b/common-guides.h >> @@ -0,0 +1,12 @@ >> +/* Automatically generated by ./generate-guidelist.sh */ >> +/* re-use struct cmdname_help in common-commands.h */ > > Huh? The first comment line fortells of patch 6 which can generate this .h file. The second comment line notes that I re-use cmdname_help, rather than creating another struct with a similar name. I should probably have noted these points in the commit message. (or waited until patch 6 to add the comment). Philip