git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / Atom feed
From: Marc Branchaud <marcnarc@xiplink.com>
To: Pratyush Yadav <me@yadavpratyush.com>,
	Allan Ford <allan.ford17@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Git Gui - enhancement suggestion - Can a double click on the file name in the “unstaged” area move the item to “staged changes”
Date: Fri, 13 Sep 2019 17:53:17 -0400
Message-ID: <3fac912d-9e3c-bf19-e1e5-2691a835b151@xiplink.com> (raw)
In-Reply-To: <20190913143229.5yop5oaascgavynl@yadavpratyush.com>

On 2019-09-13 10:32 a.m., Pratyush Yadav wrote:
> On 13/09/19 12:24PM, Allan Ford wrote:
>> Dear Git Authors,
>>
>> Not a bug, but a suggestion consideration for “Git Gui”
>>
>> Can a double click on the file name in the “unstaged” area move the
>> item to “staged changes” .. (rather than having to click on the small
>> icon to the left of the file name?)
> 
> It has been something on my radar for some time. Shouldn't be something
> too difficult to do.
> 
> While I like the idea in general, I have a question that I'd like to ask
> other git-gui users:
> 
> If we implement something like this, what happens when you single-click
> on the icon? Do we treat that as a stage/unstage command? If we keep the
> legacy behaviour of single-click on the icon stages/unstages, then a
> part of the row is single-click and the rest double-click.
> 
> If we make an entire row of the stage/unstage widget double click, it
> messes with people who are already used to it.
> 
> Is partial single and partial double click behaviour acceptable? Or
> should we make the entire row double click only? Or something else that
> I missed?

I've always felt this was a bit of user-experience failure on git-gui's 
part.  Single-click should not behave differently just because you click 
the icon.  I've seen many new git-gui users find this (mildly) confusing.

I'd be happy if the click behavior was consistent across the entire row: 
single-click to select, double-click to stage/unstage, and there's 
nothing special about clicking the icon.  I personally don't think it 
would be hard to adjust to that.

I guarantee you that if double-click support is added while preserving 
the icon-single-click, users will get tripped up when they double-click 
the icon and accidentally stage two files.

		M.


  parent reply index

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-13  2:54 Allan Ford
2019-09-13 14:32 ` Pratyush Yadav
2019-09-13 20:27   ` Bert Wesarg
2019-09-13 21:06     ` Pratyush Yadav
2019-09-14 16:07     ` David
2019-09-14 19:08       ` Pratyush Yadav
2019-09-15  3:41         ` David
2019-09-16 17:49           ` Pratyush Yadav
2019-09-13 21:53   ` Marc Branchaud [this message]
2019-09-14 15:57     ` David
2019-09-14 21:23       ` Pratyush Yadav
2019-09-15  3:42         ` David
2019-09-14  7:24   ` Johannes Sixt

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3fac912d-9e3c-bf19-e1e5-2691a835b151@xiplink.com \
    --to=marcnarc@xiplink.com \
    --cc=allan.ford17@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=me@yadavpratyush.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

git@vger.kernel.org list mirror (unofficial, one of many)

Archives are clonable:
	git clone --mirror http://public-inbox.org/git
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.version-control.git
	nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git
	nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git
	nntp://news.gmane.org/gmane.comp.version-control.git

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox