list mirror (unofficial, one of many)
 help / color / Atom feed
From: Marc Branchaud <>
To: Pratyush Yadav <>,
	Allan Ford <>
Subject: Re: Git Gui - enhancement suggestion - Can a double click on the file name in the “unstaged” area move the item to “staged changes”
Date: Fri, 13 Sep 2019 17:53:17 -0400
Message-ID: <> (raw)
In-Reply-To: <>

On 2019-09-13 10:32 a.m., Pratyush Yadav wrote:
> On 13/09/19 12:24PM, Allan Ford wrote:
>> Dear Git Authors,
>> Not a bug, but a suggestion consideration for “Git Gui”
>> Can a double click on the file name in the “unstaged” area move the
>> item to “staged changes” .. (rather than having to click on the small
>> icon to the left of the file name?)
> It has been something on my radar for some time. Shouldn't be something
> too difficult to do.
> While I like the idea in general, I have a question that I'd like to ask
> other git-gui users:
> If we implement something like this, what happens when you single-click
> on the icon? Do we treat that as a stage/unstage command? If we keep the
> legacy behaviour of single-click on the icon stages/unstages, then a
> part of the row is single-click and the rest double-click.
> If we make an entire row of the stage/unstage widget double click, it
> messes with people who are already used to it.
> Is partial single and partial double click behaviour acceptable? Or
> should we make the entire row double click only? Or something else that
> I missed?

I've always felt this was a bit of user-experience failure on git-gui's 
part.  Single-click should not behave differently just because you click 
the icon.  I've seen many new git-gui users find this (mildly) confusing.

I'd be happy if the click behavior was consistent across the entire row: 
single-click to select, double-click to stage/unstage, and there's 
nothing special about clicking the icon.  I personally don't think it 
would be hard to adjust to that.

I guarantee you that if double-click support is added while preserving 
the icon-single-click, users will get tripped up when they double-click 
the icon and accidentally stage two files.


  parent reply index

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-13  2:54 Allan Ford
2019-09-13 14:32 ` Pratyush Yadav
2019-09-13 20:27   ` Bert Wesarg
2019-09-13 21:06     ` Pratyush Yadav
2019-09-14 16:07     ` David
2019-09-14 19:08       ` Pratyush Yadav
2019-09-15  3:41         ` David
2019-09-16 17:49           ` Pratyush Yadav
2019-09-13 21:53   ` Marc Branchaud [this message]
2019-09-14 15:57     ` David
2019-09-14 21:23       ` Pratyush Yadav
2019-09-15  3:42         ` David
2019-09-14  7:24   ` Johannes Sixt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link list mirror (unofficial, one of many)

Archives are clonable:
	git clone --mirror
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Example config snippet for mirrors

Newsgroups are available over NNTP:

 note: .onion URLs require Tor:

AGPL code for this site: git clone