From: Bert Wesarg <bert.wesarg@googlemail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Ira Weiny <weiny2@llnl.gov>,
Brian Behlendorf <behlendorf1@llnl.gov>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] Add "list" and "rm" sub commands to tg-depend
Date: Thu, 9 Apr 2009 19:34:06 +0200 [thread overview]
Message-ID: <36ca99e90904091034m4d4d31dct78acb333612e678@mail.gmail.com> (raw)
In-Reply-To: <20090409124337.GA6034@pengutronix.de>
2009/4/9 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>:
> Hello Ira,
>
> On Wed, Apr 08, 2009 at 09:19:49AM -0700, Ira Weiny wrote:
>> On Wed, 8 Apr 2009 10:39:55 +0200
>> Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
>>
>> > Hello,
>> >
>> > On Wed, Apr 08, 2009 at 10:08:24AM +0200, Petr Baudis wrote:
>> > > > I tried to update the tg-depend.txt but it was listed in the .gitignore? I suspect that is because it is stored somewhere else? I have attached a new version of that file as well. (Sorry it is not in the patch.)
>> > tg-$command.txt is created by spliting README.
>>
>> Cool, thanks.
> You're welcome. I'm glad you're sending patches.
>
>> > > > + fi
>> > > > + TMPFILE=`mktemp` || exit 1
>> > > > + echo $TMPFILE
>> > > > + grep -v public-ibmad-port $root_dir/.topdeps > $TMPFILE
>> > public-ibmad-port?
>>
>> Ok, I am pretty stupid for this one, sorry.
> np
>
>> > > > + mv $TMPFILE $root_dir/.topdeps
>> > > > +else
>> > > > + echo "$name" >>"$root_dir/.topdeps"
>> > > > +fi
>> > > > +
>> > > > +## commit it and update this branch
>> > > > git add -f "$root_dir/.topdeps"
>> > > > git commit -m"New TopGit dependency: $name"
>> > > > $tg update
>> > > > --
>> > > > 1.5.4.5
>> > I don't think the patch is correct. Just removing a branch from
>> > .topdeps is not enough.
>> >
>> > Did you try to export the tg-branch? The result will be that the patch
>> > for that you deleted the dependency has the deleted change folded in.
>>
>> Indeed you are correct. It was working for me because I was moving a node
>> from one place to another. But the new location was still an ancestor of the
>> dependency which was removed. I still think this can be automated but I will
>> have to work on it.
> So you mean that rm should only work if the patch is still a dependency?
>
> You might want to check
>
> http://thread.gmane.org/gmane.comp.version-control.git/114581
>
> before investing time to implement it. (I cc:d Bert Wesarg.) If you
> had posted to git@vger.kernel.org Bert might have seen your mail alone.
> (hint hint)
Uwe,
thanks for the Cc.
I really can't reconstruct this thread, could some one send me the
original patch. My interest is this, that I implemented a tg-prev
(lists all deps from given topic), tg-next (lists topics depending on
the given topic), and a tg-tsort (which gives a topological list of
dependencies, which is a little outdated after the --graphviz option)
The original message seems lost in the archive, the comments are still there:
http://thread.gmane.org/gmane.comp.version-control.git/96483
I can send an update on this.
I think the first two commands could be added as sub-commands to
tg-depend, with bash completion you don't need to type that much
nowadays.
As I said to tg-tsort, its probably outdated because of the graphviz
output, but may still provide valid information. Btw. does anyone
know a console output driver for the graphviz tools, i.e. dot and co?
Bert
>
> Best regards
> Uwe
PS: Finally added git list to Cc:
next parent reply other threads:[~2009-04-09 17:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090407133329.57b06727.weiny2@llnl.gov>
[not found] ` <20090408080824.GF8940@machine.or.cz>
[not found] ` <20090408083955.GA28482@pengutronix.de>
[not found] ` <20090408091949.8a648d83.weiny2@llnl.gov>
[not found] ` <20090409124337.GA6034@pengutronix.de>
2009-04-09 17:34 ` Bert Wesarg [this message]
2009-04-09 18:18 ` [PATCH] Add "list" and "rm" sub commands to tg-depend Ira Weiny
[not found] ` <20090409091021.5a7ded79.weiny2@llnl.gov>
2009-04-09 18:01 ` Bert Wesarg
2009-04-09 20:15 ` Uwe Kleine-König
2009-04-11 15:40 ` Bert Wesarg
2009-04-11 19:06 ` Uwe Kleine-König
2009-04-11 19:29 ` Bert Wesarg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36ca99e90904091034m4d4d31dct78acb333612e678@mail.gmail.com \
--to=bert.wesarg@googlemail.com \
--cc=behlendorf1@llnl.gov \
--cc=git@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=weiny2@llnl.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).