From: Ben Peart <peartben@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Christian Couder <christian.couder@gmail.com>,
git <git@vger.kernel.org>, Ben Peart <benpeart@microsoft.com>,
Nguyen Thai Ngoc Duy <pclouds@gmail.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>,
David Turner <David.Turner@twosigma.com>,
Jeff King <peff@peff.net>
Subject: Re: [PATCH v3 4/6] fsmonitor: add test cases for fsmonitor extension
Date: Tue, 30 May 2017 20:10:09 -0400 [thread overview]
Message-ID: <35520cf4-6a73-29cb-e058-a0e7e29bfdce@gmail.com> (raw)
In-Reply-To: <xmqqa85uas42.fsf@gitster.mtv.corp.google.com>
On 5/30/2017 6:37 PM, Junio C Hamano wrote:
> Ben Peart <peartben@gmail.com> writes:
>
>> I did a quick search through the existing test scripts and the
>> majority do not link commands together with && when they are in a sub
>> function like this. I find not having them linked together is easier
>> to write, maintain and is more readable.
>
> I had an impression that it is true only when the series of commands
> are not about Git. When testing git commands, we should expect any
> of them to be broken (by somebody else ;-) and prepare to notice it.
>
Fixed
next prev parent reply other threads:[~2017-05-31 0:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-25 18:36 [PATCH v3 0/6] Fast git status via a file system watcher Ben Peart
2017-05-25 18:36 ` [PATCH v3 1/6] bswap: add 64 bit endianness helper get_be64 Ben Peart
2017-05-25 18:36 ` [PATCH v3 2/6] dir: make lookup_untracked() available outside of dir.c Ben Peart
2017-05-25 18:36 ` [PATCH v3 3/6] fsmonitor: teach git to optionally utilize a file system monitor to speed up detecting new or changed files Ben Peart
2017-05-25 18:36 ` [PATCH v3 4/6] fsmonitor: add test cases for fsmonitor extension Ben Peart
2017-05-30 13:18 ` Christian Couder
2017-05-30 21:21 ` Ben Peart
2017-05-30 22:37 ` Junio C Hamano
2017-05-31 0:10 ` Ben Peart [this message]
2017-05-31 4:33 ` Christian Couder
2017-05-31 14:57 ` Ben Peart
2017-05-25 18:36 ` [PATCH v3 5/6] fsmonitor: add documentation for the " Ben Peart
2017-05-25 18:36 ` [PATCH v3 6/6] fsmonitor: add a sample query-fsmonitor hook script for Watchman Ben Peart
2017-05-31 13:21 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35520cf4-6a73-29cb-e058-a0e7e29bfdce@gmail.com \
--to=peartben@gmail.com \
--cc=David.Turner@twosigma.com \
--cc=benpeart@microsoft.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).