From: Phillip Wood <phillip.wood123@gmail.com>
To: Patrick Steinhardt <ps@pks.im>, git@vger.kernel.org
Subject: Re: [PATCH 0/5] global: drop external `the_index` variable
Date: Mon, 15 Apr 2024 14:55:07 +0100 [thread overview]
Message-ID: <28541f00-9054-4aa0-8e47-348043b5f863@gmail.com> (raw)
In-Reply-To: <cover.1713180749.git.ps@pks.im>
Hi Patrick
On 15/04/2024 12:42, Patrick Steinhardt wrote:
> The motivation of these patches comes from the introduction of the ref
> format extension. I found it really hard to reason about the state of
> `the_repository` and would like to continue its deprecation in favor of
> explicitly passing down a `struct repository *`. Getting rid of
> `the_index` is a first easy step into that direction to make things more
> self-contained.
Maybe I've got the wrong end of the stick but my impression is that it
is the use of "the_repository" in library code (i.e. the files outside
builtin/) that causes most of the pain. With that in mind would be we
better focusing contributor and reviewer effort on eliminating
"the_repository" from those files instead? It would need to be done in
carefully in stages but would bring real benefits.
Best Wishes
Phillip
> Patrick
>
> Patrick Steinhardt (5):
> t/helper: stop using `the_index`
> builtin: stop using `the_index`
> repository: initialize index in `repo_init()`
> builtin/clone: stop using `the_index`
> repository: drop global `the_index` variable
>
> builtin/add.c | 48 +++++------
> builtin/am.c | 36 ++++----
> builtin/cat-file.c | 3 +-
> builtin/check-attr.c | 5 +-
> builtin/check-ignore.c | 7 +-
> builtin/checkout-index.c | 22 ++---
> builtin/checkout.c | 87 ++++++++++---------
> builtin/clean.c | 7 +-
> builtin/clone.c | 7 +-
> builtin/commit.c | 81 +++++++++---------
> builtin/describe.c | 3 +-
> builtin/diff-tree.c | 3 +-
> builtin/diff.c | 6 +-
> builtin/difftool.c | 4 +-
> builtin/merge-index.c | 17 ++--
> builtin/merge-tree.c | 3 +-
> builtin/merge.c | 31 ++++---
> builtin/mv.c | 68 +++++++--------
> builtin/pull.c | 4 +-
> builtin/read-tree.c | 15 ++--
> builtin/rebase.c | 3 +-
> builtin/replay.c | 1 -
> builtin/reset.c | 32 +++----
> builtin/rev-parse.c | 6 +-
> builtin/rm.c | 40 ++++-----
> builtin/stash.c | 45 +++++-----
> builtin/submodule--helper.c | 21 +++--
> builtin/update-index.c | 122 +++++++++++++--------------
> builtin/write-tree.c | 6 +-
> repository.c | 32 ++++---
> repository.h | 3 -
> t/helper/test-cache-tree.c | 17 ++--
> t/helper/test-dump-cache-tree.c | 5 +-
> t/helper/test-dump-split-index.c | 11 ++-
> t/helper/test-dump-untracked-cache.c | 3 +-
> t/helper/test-lazy-init-name-hash.c | 39 +++++----
> t/helper/test-read-cache.c | 9 +-
> t/helper/test-scrap-cache-tree.c | 7 +-
> t/helper/test-write-cache.c | 3 +-
> 39 files changed, 420 insertions(+), 442 deletions(-)
>
next prev parent reply other threads:[~2024-04-15 13:55 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 11:42 [PATCH 0/5] global: drop external `the_index` variable Patrick Steinhardt
2024-04-15 11:42 ` [PATCH 1/5] t/helper: stop using `the_index` Patrick Steinhardt
2024-04-17 17:23 ` Karthik Nayak
2024-04-15 11:42 ` [PATCH 2/5] builtin: " Patrick Steinhardt
2024-04-17 17:32 ` Karthik Nayak
2024-04-18 12:16 ` Patrick Steinhardt
2024-04-15 11:42 ` [PATCH 3/5] repository: initialize index in `repo_init()` Patrick Steinhardt
2024-04-17 17:38 ` Karthik Nayak
2024-04-18 12:16 ` Patrick Steinhardt
2024-04-15 11:43 ` [PATCH 4/5] builtin/clone: stop using `the_index` Patrick Steinhardt
2024-04-15 11:43 ` [PATCH 5/5] repository: drop global `the_index` variable Patrick Steinhardt
2024-04-15 13:55 ` Phillip Wood [this message]
2024-04-15 14:15 ` [PATCH 0/5] global: drop external " Patrick Steinhardt
2024-04-15 17:50 ` Junio C Hamano
2024-04-16 5:27 ` Patrick Steinhardt
2024-04-17 17:40 ` Karthik Nayak
2024-04-18 12:16 ` Patrick Steinhardt
2024-04-18 12:14 ` [PATCH v2 0/6] global: drop " Patrick Steinhardt
2024-04-18 12:14 ` [PATCH v2 1/6] t/helper: stop using `the_index` Patrick Steinhardt
2024-04-18 12:14 ` [PATCH v2 2/6] builtin: " Patrick Steinhardt
2024-04-18 12:14 ` [PATCH v2 3/6] repository: initialize index in `repo_init()` Patrick Steinhardt
2024-04-18 12:14 ` [PATCH v2 4/6] builtin/clone: stop using `the_index` Patrick Steinhardt
2024-04-18 12:14 ` [PATCH v2 5/6] repository: drop `the_index` variable Patrick Steinhardt
2024-04-18 12:14 ` [PATCH v2 6/6] repository: drop `initialize_the_repository()` Patrick Steinhardt
2024-04-18 19:36 ` [PATCH v2 0/6] global: drop `the_index` variable Junio C Hamano
2024-04-19 4:25 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28541f00-9054-4aa0-8e47-348043b5f863@gmail.com \
--to=phillip.wood123@gmail.com \
--cc=git@vger.kernel.org \
--cc=phillip.wood@dunelm.org.uk \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).