From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: "brian m. carlson" <sandals@crustytoothpaste.net>, git@vger.kernel.org
Subject: Re: Do porcelain command require lock management?
Date: Mon, 26 Oct 2020 12:36:43 -0400 [thread overview]
Message-ID: <20201026163643.6cp4jwj5lqkg6vns@chatter.i7.local> (raw)
In-Reply-To: <20201025230203.GH860779@camp.crustytoothpaste.net>
On Sun, Oct 25, 2020 at 11:02:03PM +0000, brian m. carlson wrote:
> > A script I'm writing performs a succession of porcelain commands to
> > create a commit in a bare git repository:
> >
> > git hash-object
> > git mktree
> > git commit-tree
> > git update-ref
> >
> > Do I need to manage external locking around these commands to avoid any
> > concurrency problems, or will git take care of that?
>
> I'm almost certain that Git will do the same locking and object creation
> semantics that it does in porcelain commands as in the plumbing commands
> you're using. For example, I happen to know that all loose object
> creation goes through one function, which should gracefully handle
> concurrent accesses. Git is in general safe against concurrent accesses
> and is designed not to lose or corrupt data in this case.
>
> However, I will point out that ref updates may conflict and if so, Git
> will fail instead of waiting. So while your repository will remain
> consistent and won't experience corruption, that doesn't mean that all
> operations will complete successfully. Some sort of retry mechanism or
> other error handling will probably be warranted.
Thanks for your advice. I think in this case it's easier to just use
simple locking to make sure that concurrent processes don't step on
each-other's toes.
Best regards,
-K
next prev parent reply other threads:[~2020-10-26 16:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-24 14:46 Do porcelain command require lock management? Konstantin Ryabitsev
2020-10-25 23:02 ` brian m. carlson
2020-10-26 16:36 ` Konstantin Ryabitsev [this message]
2020-10-26 17:56 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201026163643.6cp4jwj5lqkg6vns@chatter.i7.local \
--to=konstantin@linuxfoundation.org \
--cc=git@vger.kernel.org \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).