From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id EC5471F4B4 for ; Wed, 21 Oct 2020 20:52:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2505536AbgJUUwP (ORCPT ); Wed, 21 Oct 2020 16:52:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2505533AbgJUUwP (ORCPT ); Wed, 21 Oct 2020 16:52:15 -0400 Received: from mail-qv1-xf44.google.com (mail-qv1-xf44.google.com [IPv6:2607:f8b0:4864:20::f44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DE50C0613CE for ; Wed, 21 Oct 2020 13:52:13 -0700 (PDT) Received: by mail-qv1-xf44.google.com with SMTP id t6so1891032qvz.4 for ; Wed, 21 Oct 2020 13:52:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ttaylorr-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=OUX3EmckT38r0xkFw12YoMyWgyWOHbnLoSkZ9qMt80I=; b=jMMG9DYsZCM0kFio8cdfRmYT7V/+Zr7iY7LwR3cPeFwFi4qGdChrNi+LdueHbw7tDd 8RPg2kZLtL7MVGoeYd6Wmz75Q+IpMYtJjJsi8KlosXkjmAYfm+Dxf0G8CFVbDwAS64PH i1kExLvpUl0Clvs7A+Ey2oL8hHgFLS/nv4xVgUgvFKS9pf2DowC6GjfkTzpw/7gGEucH Xrd73A3B24SBQJ9MXOZAqxPK494ItEeoQfLrsaBJktQ7WPd0xxQHhclPnT1+L539I/Lp pndYCZgyaYdylWSTyk1wY4NHtvf4zrmAS5M4DkltJRFKwnssmAmQheJzP+Le4wz2ioDv 6oLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=OUX3EmckT38r0xkFw12YoMyWgyWOHbnLoSkZ9qMt80I=; b=iIiMWTO1aR/FksRDpNNpeuKlKc8GAhz2EedLGg8uYAc/CwZir22cQjIN3BVFmU0ffN fdM/T8ENTmM7YCx8lSg4FB+PlAzffG9aGPfAny4pjUfaGUByhtT3vfbJliBmMg4rFSFD YdMfV6eXEa1i5Fxov/jgJpucHg56hWRA5NmWbRejpETu33E/FBNJ+dxpC7CbM/odEMzN Jgt6JObiw1CI0mpm+rSPxrAlNVVc42FUkrVSBMFzVktHhUNpb779wwdLELJ7cpm16G0J PGtY3A4SYXOddoBAPs/eM+1nasoBplOoeDieV+zJ14JKrezBLWc2mAjS9GI+oc6E3YaI Z0pg== X-Gm-Message-State: AOAM5330mia3AJK4Lns70Me1zjH3CUSQXFi0NIh24Cj0zw7Z+i6INGaA hMQE+EKPCNxt9SORGNXO0KplFg== X-Google-Smtp-Source: ABdhPJy4YLsx3xSzJS/qZoA03UeN8p4YtFrhwEZtKz6OTeM0HxtdQFS6VQ/W1GckKowvvKwpmTp12Q== X-Received: by 2002:a0c:edb1:: with SMTP id h17mr4316108qvr.7.1603313532838; Wed, 21 Oct 2020 13:52:12 -0700 (PDT) Received: from localhost ([2605:9480:22e:ff10:5440:c3ba:60f:b745]) by smtp.gmail.com with ESMTPSA id 61sm2019985qta.19.2020.10.21.13.52.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Oct 2020 13:52:11 -0700 (PDT) Date: Wed, 21 Oct 2020 16:52:08 -0400 From: Taylor Blau To: Nipunn Koorapati via GitGitGadget Cc: git@vger.kernel.org, Nipunn Koorapati Subject: Re: [PATCH 0/2] fsmonitor inline / testing cleanup Message-ID: <20201021205208.GA1270359@nand.local> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Hi Nipunn, On Wed, Oct 21, 2020 at 06:04:32PM +0000, Nipunn Koorapati via GitGitGadget wrote: > Credit to alexmv again - I'm rebasing these changes from a couple years ago > for contribution. > > Full comments are available here - > https://public-inbox.org/git/01ad47b4-aa5e-461a-270b-dd60032afbd1@gmail.com/ > To summarize the relevant points I'm fine with both of these patches, but it may help to have a bit more information about how they will be used. Presumably more patches are coming that make use of the new public functions, but it'd be good to know a little bit of why these changes are necessary. Thanks, Taylor