From: Rafael Aquini <aquini@redhat.com>
To: Carlo Arenas <carenas@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] send-email: restore --in-reply-to superseding behavior
Date: Fri, 26 Jun 2020 09:39:47 -0400 [thread overview]
Message-ID: <20200626133947.GB2235017@optiplex-lnx> (raw)
In-Reply-To: <CAPUEspgoDUGUmFqoKkmKDpRzSB5dQNb+PasaPjbPwb04SBz=Ww@mail.gmail.com>
On Thu, Jun 25, 2020 at 06:08:24PM -0700, Carlo Arenas wrote:
> a test case in t/t9001-send-email.sh will also help, as I am not sure
> this might be "expected behaviour" as hinted in the man page for
> git-send-email (under --thread):
>
> "It is up to the user to ensure that no In-Reply-To header already exists
> exists when git send-email is asked to add it (especially note that
> git format-patch can be configured to do the threading itself).
> Failure to do so may not produce the expected result in the
> recipient's MUA."
>
A quick note: this change does not break that assumption, as well.
The "ensure it exists" part means the header must either be in the
messages, as populated by format-patch, or it is provided by the
--in-reply-to switch option. send-email --thread is not orthogonal,
but complementar with --in-reply-to, AFAICS.
The problem we have, right now, is that "send-email --in-reply-to" input gets
dropped on the floor if you don't explicitly do "format-patch --no-thread" (or
extract a single patch), and this is a behavior regression introduced after v2.17.2
I took a glance in the test-cases, an it seems this is already covered:
test_expect_success $PREREQ 'in-reply-to but no threading' '
git send-email \
--dry-run \
--from="Example <nobody@example.com>" \
--to=nobody@example.com \
--in-reply-to="<in-reply-id@example.com>" \
--no-thread \
$patches >out &&
grep "In-Reply-To: <in-reply-id@example.com>" out
'
Cheers,
-- Rafael
next prev parent reply other threads:[~2020-06-26 13:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 19:55 [PATCH] send-email: restore --in-reply-to superseding behavior Rafael Aquini
2020-06-24 21:33 ` Junio C Hamano
2020-06-24 23:45 ` Rafael Aquini
2020-06-25 18:47 ` Rafael Aquini
2020-06-26 1:08 ` Carlo Arenas
2020-06-26 13:39 ` Rafael Aquini [this message]
2020-06-29 14:11 ` [PATCH v2] " Rafael Aquini
2020-07-01 22:10 ` Carlo Marcelo Arenas Belón
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200626133947.GB2235017@optiplex-lnx \
--to=aquini@redhat.com \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).