From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Tibor Billes <tbilles@gmx.com>, git@vger.kernel.org
Subject: Re: [PATCH] fast-import: fix incomplete conversion with multiple mark files
Date: Mon, 8 Jun 2020 22:58:20 +0000 [thread overview]
Message-ID: <20200608225820.GM6569@camp.crustytoothpaste.net> (raw)
In-Reply-To: <xmqqtuzlld1d.fsf@gitster.c.googlers.com>
[-- Attachment #1: Type: text/plain, Size: 959 bytes --]
On 2020-06-08 at 16:47:58, Junio C Hamano wrote:
> Brian, I notice that the singleton global "marks_set_count", even
> though the number could be counted per instance of the mark_set
> structure, is still singleton. I didn't bother thinking about it
> when I wrote my "perhaps along this line" patch, but now I read it
> again, I think it is OK to leave it (and other stats counters) as
> is, primarily because we don't have a need (yet) to show stats per
> mark_set. Did you leave it as a global for the same reason? Just
> sanity-checking.
Yes, I did; sorry for not mentioning that in the commit message. I
think it's fine to count the total number of marks processed as a
statistic, and that would be independent of how we processed them. It's
an interesting metric, but not so interesting that folks will have a
need to see a detailed breakdown, I think.
--
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
prev parent reply other threads:[~2020-06-08 22:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 5:15 git-fast-import out of memory Billes Tibor
2020-06-05 22:43 ` brian m. carlson
2020-06-06 0:22 ` [PATCH] fast-import: fix incomplete conversion with multiple mark files brian m. carlson
2020-06-06 0:22 ` [PATCH v2 0/1] Run pipeline command in subshell in sh mode brian m. carlson
2020-06-06 0:31 ` brian m. carlson
2020-06-06 0:22 ` [PATCH v2] exec: run final pipeline command in a " brian m. carlson
2020-06-08 15:52 ` [PATCH] fast-import: fix incomplete conversion with multiple mark files Tibor Billes
2020-06-08 16:47 ` Junio C Hamano
2020-06-08 22:58 ` brian m. carlson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200608225820.GM6569@camp.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=tbilles@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).