From: Jeff King <peff@peff.net>
To: "Đoàn Trần Công Danh" <congdanhqx@gmail.com>
Cc: git@vger.kernel.org, Jeff Hostetler <jeffhost@microsoft.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>,
Taylor Blau <me@ttaylorr.com>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v3 1/3] SubmittingPatches: advertise GitHub Actions CI
Date: Tue, 5 May 2020 13:07:37 -0400 [thread overview]
Message-ID: <20200505170737.GE64077@coredump.intra.peff.net> (raw)
In-Reply-To: <20200505165933.GC927@danh.dev>
On Tue, May 05, 2020 at 11:59:33PM +0700, Đoàn Trần Công Danh wrote:
> > > +Alternately, you can use GitHub Actions (which supports testing your changes
> > > +on Linux, macOS, and Windows) by pushing into a branch in your fork
> > > +or opening a GitHub's Pull Request against
> > > +https://github.com/git/git.git or a fork of that repository.
> >
> > Probably "GitHub Pull Request" would be more idiomatic English.
>
> I guess you're right.
>
> Well, I'm not native English speaker.
> I was thinking, this kind of Pull Request is specific to GitHub,
> and it's different from git-request-pull(1), So, I use "'s" :)
Using the possessive "'s" would imply you're talking about GitHub's
feature itself. But you're talking about "a" pull request, so I think
you want to just GitHub as an adjective, which would not generally be
possessive. English is quirky. :)
> > When I made a new repository that was not connected, I had to explicitly
> > enable Actions on the site before it would run the workflow file.
>
> It seems like GitHub Actions will be triggered automatically if GitHub
> finds any files in "$TOPDIR/.github/workflows/*.yml"
It definitely wasn't for me. Try creating a new repo and going to the
"Actions" tab. I get a "Get Started with GitHub Actions" page. If I push
up a copy of git.git's master, then I get "Workflows aren't being run in
this repository" with a big green button to enable.
I'm just not sure if that happens for people who fork git/git instead of
making a new repo. I'm reluctant to delete and remake my fork, but I
guess it wouldn't be too hard to re-create.
I think it's OK to leave it out for now. Even if this is how it works
for a fork, it's not hard to discover what to do if you click the
Actions tab.
-Peff
next prev parent reply other threads:[~2020-05-05 17:07 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-02 15:08 [PATCH] ci: respect the [skip ci] convention in our GitHub workflow "CI/PR" Johannes Schindelin via GitGitGadget
2020-05-03 9:36 ` Jeff King
2020-05-03 12:05 ` Danh Doan
2020-05-04 15:01 ` Jeff King
2020-05-04 15:49 ` [PATCH v2 0/2] Limit GitHub Actions to designated branches Đoàn Trần Công Danh
2020-05-04 15:49 ` [PATCH v2 1/2] CI: limit " Đoàn Trần Công Danh
2020-05-04 16:23 ` Jeff King
2020-05-04 21:58 ` Taylor Blau
2020-05-04 22:52 ` Junio C Hamano
2020-05-04 23:15 ` Taylor Blau
2020-05-04 23:35 ` Jeff King
2020-05-05 0:24 ` Junio C Hamano
2020-05-04 23:36 ` Jeff King
2020-05-05 0:20 ` Taylor Blau
2020-05-05 16:43 ` Jeff King
2020-05-05 17:57 ` Junio C Hamano
2020-05-05 18:24 ` Jeff King
2020-05-05 21:04 ` Jeff King
2020-05-05 21:29 ` Junio C Hamano
2020-05-05 21:58 ` Jeff King
2020-05-05 22:28 ` Junio C Hamano
2020-05-06 15:09 ` Johannes Schindelin
2020-05-06 16:26 ` Junio C Hamano
2020-05-07 12:17 ` Jeff King
2020-05-07 14:02 ` Jeff King
2020-05-07 18:17 ` Junio C Hamano
2020-05-07 12:01 ` Đoàn Trần Công Danh
2020-05-07 12:47 ` Đoàn Trần Công Danh
2020-05-06 0:46 ` Đoàn Trần Công Danh
2020-05-06 3:56 ` Junio C Hamano
2020-05-06 14:25 ` Đoàn Trần Công Danh
2020-05-06 16:31 ` Junio C Hamano
2020-05-07 12:25 ` Jeff King
2020-05-07 18:29 ` Junio C Hamano
2020-05-07 18:54 ` Jeff King
2020-05-07 19:33 ` Junio C Hamano
2020-05-07 16:20 ` [PATCH v2] ci: allow per-branch config for GitHub Actions Jeff King
2020-05-07 17:00 ` Taylor Blau
2020-05-07 17:18 ` Jeff King
2020-05-07 19:53 ` Junio C Hamano
2020-05-07 20:46 ` Jeff King
2020-05-07 21:58 ` Junio C Hamano
2020-05-08 18:00 ` Jeff King
2020-05-09 1:23 ` Đoàn Trần Công Danh
2020-05-05 0:34 ` [PATCH v2 1/2] CI: limit GitHub Actions to designated branches Đoàn Trần Công Danh
2020-05-04 15:49 ` [PATCH v2 2/2] SubmittingPatches: advertise GitHub Actions CI Đoàn Trần Công Danh
2020-05-04 16:37 ` Junio C Hamano
2020-05-05 0:46 ` Đoàn Trần Công Danh
2020-05-05 16:26 ` [PATCH v3 0/3] Provide option to opt in/out GitHub Actions Đoàn Trần Công Danh
2020-05-05 16:26 ` [PATCH v3 1/3] SubmittingPatches: advertise GitHub Actions CI Đoàn Trần Công Danh
2020-05-05 16:47 ` Jeff King
2020-05-05 16:59 ` Đoàn Trần Công Danh
2020-05-05 17:07 ` Jeff King [this message]
2020-05-05 16:26 ` [PATCH v3 2/3] CI: limit GitHub Actions to designated branches Đoàn Trần Công Danh
2020-05-05 16:51 ` Jeff King
2020-05-05 17:05 ` Đoàn Trần Công Danh
2020-05-05 17:11 ` Jeff King
2020-05-05 18:49 ` Junio C Hamano
2020-05-05 16:26 ` [PATCH v3 3/3] fixup! " Đoàn Trần Công Danh
2020-05-05 18:59 ` Junio C Hamano
2020-05-05 17:01 ` [PATCH v3 0/3] Provide option to opt in/out GitHub Actions Jeff King
2020-05-03 16:46 ` [PATCH] ci: respect the [skip ci] convention in our GitHub workflow "CI/PR" Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200505170737.GE64077@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=congdanhqx@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jeffhost@microsoft.com \
--cc=johannes.schindelin@gmx.de \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).