From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id C82D21F8C1 for ; Tue, 5 May 2020 16:51:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729877AbgEEQv0 (ORCPT ); Tue, 5 May 2020 12:51:26 -0400 Received: from cloud.peff.net ([104.130.231.41]:37958 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1729119AbgEEQv0 (ORCPT ); Tue, 5 May 2020 12:51:26 -0400 Received: (qmail 13437 invoked by uid 109); 5 May 2020 16:51:26 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Tue, 05 May 2020 16:51:26 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 31519 invoked by uid 111); 5 May 2020 16:51:26 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Tue, 05 May 2020 12:51:26 -0400 Authentication-Results: peff.net; auth=none Date: Tue, 5 May 2020 12:51:25 -0400 From: Jeff King To: =?utf-8?B?xJBvw6BuIFRy4bqnbiBDw7RuZw==?= Danh Cc: git@vger.kernel.org, Jeff Hostetler , Johannes Schindelin , Taylor Blau , Junio C Hamano Subject: Re: [PATCH v3 2/3] CI: limit GitHub Actions to designated branches Message-ID: <20200505165125.GC64077@coredump.intra.peff.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, May 05, 2020 at 11:26:40PM +0700, Đoàn Trần Công Danh wrote: > -on: [push, pull_request] > +on: > + pull_request: > + push: > + branches: > + - maint > + - master > + - next > + - jch > + - pu > + - 'for-ci**' Should this be "for-ci/**", or are we intending for "for-ci-foo" to work? I'd suspect anybody who uses this would use a full directory namespace in a refspec (like "refs/heads/*:refs/heads/for-ci/*"). It might be simpler conceptually to only support that. > + tags: > + - '**' > + - '!**wip**' IMHO this "wip" match is going too far. That was the name in the example I used, but really it could have been anything. I think we should either: - just build all tags; it usually takes special effort to push them up anyway, so a one-off "just mark this spot" tag likely wouldn't get pushed anyway - just build v[0-9]*, which would catch actual releases -Peff