From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 147931F8C1 for ; Tue, 5 May 2020 01:40:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727786AbgEEBjp (ORCPT ); Mon, 4 May 2020 21:39:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726516AbgEEBjo (ORCPT ); Mon, 4 May 2020 21:39:44 -0400 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83F5AC061A0F for ; Mon, 4 May 2020 18:39:43 -0700 (PDT) Received: by mail-pl1-x642.google.com with SMTP id w3so161022plz.5 for ; Mon, 04 May 2020 18:39:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Rdd23K0VKYArxPfWBu9HOIWcLwj56JRKrRMqxp2eb6U=; b=oAalX+HKNsIdHtiC1q2iYZOLzU76FjjgFMK0zyKeca+cxA0/zxNdJwUnmPymm0agA+ 6Nm7DU3p/CVi+lcQyHQpr54ujrQcvzqvJEGPHPtvmOP6o7Ap3P3dFMiwnEAOxOP/cQmH abObbRmhHfDMyv9FaLbuWHVfhGpl895mQKN1F5wXTvLxy/i4gNHKXOMIcPuHJMyZFS6P h1ps+p+yvYPLMNVgSBdKdLr/SggAw8bOKIEdG9Hr3pK/R2mv6vU8AO/CA4gpekPGxHcX hjtqzl1HXn/97T4NzucTzynPDYFQon2TNQRbCSiq/hrPSyN0wQ+rsHJZqUOMecFatMgq lRnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Rdd23K0VKYArxPfWBu9HOIWcLwj56JRKrRMqxp2eb6U=; b=bcrfIPWy5EC/+ZubpLmrjxlZrce/2881MfM8cAYGq233fzB2ehWCwoweSfgzKWf38C S7c8Zf2esMSCBhUqsd2DPbalL/i+YXV0oN9+/KNQjhmJtfLoeZwgDuBh6NGSKqf3OEN6 sz9EsQR3gF4IlrrtuGZCmue+WVzGxFjTqf3c6Jqn7ZjI5MCPX8wB/5E1EUUIwJGPd/LS SxeYoO0UsoRSt21JZLQOT9ooS/O7WbXecKppeniE7w0GVZbUqbVHV1KKs2IiJ4t65ZX3 Y4Mcqp1+BwZuW6Qm/NUqZcRyAfq9BZUEg2hOSr+GDUJujTNiQ5aAgd2kxA/kdDZgmnOl i9DA== X-Gm-Message-State: AGi0PuavYTagoQziDd3YaxEltNsV9TrbkoixiQ6F3ICRYxgLy8WkMdWL /IhoII4WUYbdfCrOws2Yz0oqnf0K X-Google-Smtp-Source: APiQypKCuuwX3bAB1LKnwJkKZZ+iVjkzj/AaIaBQiOo1LM0eLr+bly5kZEglkUHfZ5p8xy+hK1uS7A== X-Received: by 2002:a17:902:b58e:: with SMTP id a14mr505734pls.247.1588642782780; Mon, 04 May 2020 18:39:42 -0700 (PDT) Received: from localhost.localdomain (c-67-188-192-166.hsd1.ca.comcast.net. [67.188.192.166]) by smtp.gmail.com with ESMTPSA id e196sm352027pfh.43.2020.05.04.18.39.42 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 May 2020 18:39:42 -0700 (PDT) From: =?UTF-8?q?Carlo=20Marcelo=20Arenas=20Bel=C3=B3n?= To: git@vger.kernel.org Cc: peff@peff.net, jrnieder@gmail.com, =?UTF-8?q?Carlo=20Marcelo=20Arenas=20Bel=C3=B3n?= Subject: [PATCH 2/4] credential: correct order of parameters for credential_match Date: Mon, 4 May 2020 18:39:06 -0700 Message-Id: <20200505013908.4596-3-carenas@gmail.com> X-Mailer: git-send-email 2.26.2.686.gfaf46a9ccd In-Reply-To: <20200505013908.4596-1-carenas@gmail.com> References: <20200503063423.83152-1-carenas@gmail.com> <20200505013908.4596-1-carenas@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Since the beginning in 118250728e (credential: apply helper config, 2011-12-10), the declaration for that function used a different order than the implementation. All callers use the same order than the implementation, so update the declaration in credential.h to match. Reviewed-by: Jeff King Signed-off-by: Carlo Marcelo Arenas Belón --- credential.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/credential.h b/credential.h index f51703d9ce..c0e17e3554 100644 --- a/credential.h +++ b/credential.h @@ -189,7 +189,7 @@ void credential_write(const struct credential *, FILE *); void credential_from_url(struct credential *, const char *url); int credential_from_url_gently(struct credential *, const char *url, int quiet); -int credential_match(const struct credential *have, - const struct credential *want); +int credential_match(const struct credential *want, + const struct credential *have); #endif /* CREDENTIAL_H */ -- 2.26.2.686.gfaf46a9ccd