git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Son Luong Ngoc <sluongng@gmail.com>
Cc: git <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: Seg Fault on git fetch with fetch.negotiationAlgorithm=skipping
Date: Thu, 30 Apr 2020 14:20:14 -0600	[thread overview]
Message-ID: <20200430202014.GB2014@syl.local> (raw)
In-Reply-To: <450D5CC7-113A-40D8-9CD4-53786198526D@gmail.com>

Hi Son,

On Thu, Apr 30, 2020 at 04:55:07PM +0200, Son Luong Ngoc wrote:
> Hi folks,
>
> We recently encountered a segfault during a git fetch
> strace output could be found https://gist.github.com/sluongng/e48327cc911c617ed2ef8578acc2ea34
>
> The root cause was due to having `fetch.negotiationAlgorithm=skipping`
> The repo is about linux.git size with a few NULL commit that we have been using `fsck.skipList`
> on both server and client side to skip.

Are you able to share a core file? If not, it would be very helpful for
you to 'git fast-export --anonymize ...' and see if you can reproduce
the problem on an anonymized copy of your repository.

I can speculate about the cause of the crash from your strace above, but
a core file would be more helpful.

> Is this and edge case for the new algorithm?
>
> Cheers,
> Son Luong.

Thanks,
Taylor

  reply	other threads:[~2020-04-30 20:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-30 14:55 Seg Fault on git fetch with fetch.negotiationAlgorithm=skipping Son Luong Ngoc
2020-04-30 20:20 ` Taylor Blau [this message]
2020-05-01  8:13   ` Son Luong Ngoc
2020-05-01 22:13     ` Taylor Blau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200430202014.GB2014@syl.local \
    --to=me@ttaylorr.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=sluongng@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).