From: Taylor Blau <me@ttaylorr.com>
To: Doug Glidden <41mortimer@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: git fast-export not preserving executable permissions?
Date: Wed, 29 Apr 2020 12:49:09 -0600 [thread overview]
Message-ID: <20200429184909.GE83442@syl.local> (raw)
In-Reply-To: <CAHTRwmjXXYAU_LTBF_9sX1CXFnGyHsu5_KHuCp1rB76-4zn=Gg@mail.gmail.com>
Hi Doug,
On Wed, Apr 29, 2020 at 09:36:31AM -0400, Doug Glidden wrote:
> Hello Git world!
>
> I have run into an issue that I cannot seem to resolve with git
> fast-export. When running a fast-export on a repo that contains
> scripts with executable permissions (e.g. a gradlew script), the
> resulting export does not properly reflect the executable permissions
> on the script files.
Interesting. fast-import and fast-export both understand executable
modes (although Git only understands the modes 644 and 755 for blobs),
so this should be working.
I can not reproduce the issue as-is. Round-tripping a fast-import and
fast-export preserves executable bits for me:
#!/bin/bash
set -e
rm -rf repo client
git init -q repo
git init -q client
(
cd repo
printf "x" >x
printf "y" >y
chmod +x x
git add x y
git commit -q -m "initial commit"
)
git -C repo fast-export HEAD | git -C client fast-import
diff -u <(git -C repo ls-tree HEAD) <(git -C client ls-tree HEAD)
> To illustrate this issue, I created a small sample repo, with one
> executable file and one non-executable file. From the output below,
> you can see that the mode in the output from fast-export is the same
> for both files; according to the documentation for fast-import, the
> mode for the executable file should be 100755 instead of 100644.
>
> $ ls -gG
> total 2
> -rwxr-xr-x 1 106 Apr 29 09:13 executable_script.sh*
> -rw-r--r-- 1 63 Apr 29 09:12 non_executable_file.txt
>
> $ git fast-export --all
> blob
> mark :1
> data 106
> #!/bin/bash
>
> # This is a shell script that should be executable.
> echo 'The script executed successfully!'
>
> blob
> mark :2
> data 63
> This file is a simple text file that should not be executable.
>
> reset refs/heads/dev
> commit refs/heads/dev
> mark :3
> author Doug <41mortimer@gmail.com> 1588167102 -0400
> committer Doug <41mortimer@gmail.com> 1588167102 -0400
> data 25
> Adding some sample files
> M 100644 :1 executable_script.sh
> M 100644 :2 non_executable_file.txt
>
> Please let me know if there is any further information I can provide
> about this issue.
Does Git think that the file is executable? Please run 'git ls-tree
HEAD' to find out.
> Thank you,
> Doug
Thanks,
Taylor
next prev parent reply other threads:[~2020-04-29 18:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 13:36 git fast-export not preserving executable permissions? Doug Glidden
2020-04-29 18:49 ` Taylor Blau [this message]
2020-05-01 13:35 ` Doug Glidden
2020-05-01 22:32 ` Taylor Blau
2020-05-04 14:23 ` Johannes Schindelin
2020-04-30 3:42 ` Torsten Bögershausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200429184909.GE83442@syl.local \
--to=me@ttaylorr.com \
--cc=41mortimer@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).