From: Jeff King <peff@peff.net>
To: Taylor Blau <me@ttaylorr.com>
Cc: git@vger.kernel.org, chriscool@tuxfamily.org
Subject: Re: [PATCH 0/4] pack-bitmap: use bitmaps for traversals with '--filter=tree:0'
Date: Fri, 24 Apr 2020 01:43:10 -0400 [thread overview]
Message-ID: <20200424054310.GF1648190@coredump.intra.peff.net> (raw)
In-Reply-To: <cover.1587597151.git.me@ttaylorr.com>
On Wed, Apr 22, 2020 at 05:13:19PM -0600, Taylor Blau wrote:
> This series contains a handful of patches to make object traversals with
> '--filter=tree:0' be bitmaps-compatible. They have been kicking around
> in GitHub's fork for some time, and we use them on every
> '--filter=tree:0' fetch.
As an author of half the patches, you can take my review with a grain of
salt, but these all look good to me (modulo one typo fix in a commit
message).
-Peff
next prev parent reply other threads:[~2020-04-24 5:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 23:13 [PATCH 0/4] pack-bitmap: use bitmaps for traversals with '--filter=tree:0' Taylor Blau
2020-04-22 23:13 ` [PATCH 1/4] list-objects-filter: treat NULL filter_options as "disabled" Taylor Blau
2020-04-22 23:13 ` [PATCH 2/4] pack-bitmap.c: make object filtering functions generic Taylor Blau
2020-04-22 23:13 ` [PATCH 3/4] pack-bitmap.c: support 'tree:0' filtering Taylor Blau
2020-04-22 23:13 ` [PATCH 4/4] pack-bitmap: pass object filter to fill-in traversal Taylor Blau
2020-04-24 5:42 ` Jeff King
2020-04-24 16:54 ` Taylor Blau
2020-04-24 5:43 ` Jeff King [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-05-04 23:12 [PATCH 0/4] pack-bitmap: use bitmaps for traversals with '--filter=tree:0' Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200424054310.GF1648190@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).