From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id DCFAF1F45A for ; Tue, 21 Apr 2020 02:23:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726793AbgDUCXV (ORCPT ); Mon, 20 Apr 2020 22:23:21 -0400 Received: from aibo.runbox.com ([91.220.196.211]:49028 "EHLO aibo.runbox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725989AbgDUCXV (ORCPT ); Mon, 20 Apr 2020 22:23:21 -0400 Received: from [10.9.9.204] (helo=mailfront22.runbox) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1jQiZC-0006R0-Jd; Tue, 21 Apr 2020 04:23:18 +0200 Received: by mailfront22.runbox with esmtpsa [Authenticated alias (964124)] (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) id 1jQiYy-0003e4-OW; Tue, 21 Apr 2020 04:23:05 +0200 Date: Tue, 21 Apr 2020 02:22:56 +0000 From: Emma Brooks To: Ash Holland Cc: git@vger.kernel.org, Junio C Hamano , Boxuan Li , Alban Gruin Subject: Re: [PATCH] userdiff: support Markdown Message-ID: <20200421022256.GA29071@pluvano.com> References: <20200421010035.13915-1-ash@sorrel.sh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200421010035.13915-1-ash@sorrel.sh> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 2020-04-21 02:00:35+0100, Ash Holland wrote: > I would also appreciate feedback on the word-diff pattern here, I have > no real idea what should constitute a word in a Markdown document, apart > from that it should probably be similar to the definition given for > Fountain, given that Fountain appears to have somewhat similar inline > syntax to Markdown. Since Markdown can have raw HTML tags in many variants, it may make sense to extend the word pattern to "[^<>= \t]+" like HTML's pattern so tags starting/ending will not be considered part of a word.