From: Emma Brooks <me@pluvano.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Denton Liu <liu.denton@gmail.com>,
Eric Sunshine <sunshine@sunshineco.com>,
Jeff King <peff@peff.net>
Subject: Re: [PATCH] format-patch: teach --no-encode-headers
Date: Wed, 8 Apr 2020 04:08:04 +0000 [thread overview]
Message-ID: <20200408040746.GA41187@pluvano.com> (raw)
In-Reply-To: <xmqq8sj7t7d0.fsf@gitster.c.googlers.com>
On 2020-04-07 12:37:31-0700, Junio C Hamano wrote:
> Emma Brooks <me@pluvano.com> writes:
>
> > It's also too vague and it's not entirely clear from the option itself
> > what sort of encoding it refers to. I will change it to
> > --[no-]q-encode-headers and format.qEncodeHeaders in v2 unless there are
> > other suggestions.
>
> I actually did not mean to push you into that direction. We can,
> and do want to, keep the most generic "--[no-]encode-headers" if we
> do not anticipate us wanting to special case the Q encoding. A
> sample question to ask is "would it make sense to disable q-encoding
> but still perform other parts of 'encode headers'?" I haven't
> thought deeply about such questions, but as a proposer of this
> topic, you would certainly have, and I was hoping that you'd say
> things like "Q-encoding is the only thing that we do to munge
> headers, so there aren't any 'other parts of encoding headers' we
> need to worry about", "there are things like X, Y and Z that we do
> to the headers when we enable Q-encoding, but they all are what we
> do not want when we do not want the Q-encoding", which would be a
> very good sign that assures us that "--[no-]encode-headers" is a
> good name.
Ah. I don't think there are any cases where we do other sorts of
encoding, or want to enable one "part" of encoding and disable another.
I do think the name need to be more obviously about *email* headers as
Jeff pointed out, though.
next prev parent reply other threads:[~2020-04-08 4:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-05 23:11 [PATCH] format-patch: teach --no-encode-headers Emma Brooks
2020-04-06 3:04 ` brian m. carlson
2020-04-06 13:30 ` Jeff King
2020-04-06 15:17 ` brian m. carlson
2020-04-06 15:30 ` Jeff King
2020-04-06 3:29 ` Junio C Hamano
2020-04-07 3:46 ` Emma Brooks
2020-04-07 19:37 ` Junio C Hamano
2020-04-07 20:31 ` Jeff King
2020-04-07 22:20 ` Junio C Hamano
2020-04-08 4:08 ` Emma Brooks [this message]
2020-04-07 5:17 ` [PATCH v2] format-patch: teach --no-q-encode-headers Emma Brooks
2020-04-07 7:40 ` Danh Doan
2020-04-08 3:57 ` Emma Brooks
2020-04-08 4:31 ` [PATCH v3] format-patch: teach --no-encode-email-headers Emma Brooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200408040746.GA41187@pluvano.com \
--to=me@pluvano.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=liu.denton@gmail.com \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).