From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id CFBC11F487 for ; Sun, 29 Mar 2020 14:53:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727903AbgC2Oxo (ORCPT ); Sun, 29 Mar 2020 10:53:44 -0400 Received: from cloud.peff.net ([104.130.231.41]:54940 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1727816AbgC2Oxo (ORCPT ); Sun, 29 Mar 2020 10:53:44 -0400 Received: (qmail 2209 invoked by uid 109); 29 Mar 2020 14:53:44 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Sun, 29 Mar 2020 14:53:44 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 9248 invoked by uid 111); 29 Mar 2020 15:03:45 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Sun, 29 Mar 2020 11:03:45 -0400 Authentication-Results: peff.net; auth=none Date: Sun, 29 Mar 2020 10:53:43 -0400 From: Jeff King To: Junio C Hamano Cc: git@vger.kernel.org Subject: Re: [PATCH 1/2] test-lib-functions: make packetize() more efficient Message-ID: <20200329145343.GB15400@coredump.intra.peff.net> References: <20200327080210.GA604725@coredump.intra.peff.net> <20200327080300.GA605934@coredump.intra.peff.net> <20200328112010.GC639140@coredump.intra.peff.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Sat, Mar 28, 2020 at 08:05:10PM -0700, Junio C Hamano wrote: > -- >8 -- > Subject: CodingGuidelines: allow ${#posix} == strlen($posix) I'm in favor of this patch, but... > The construct has been in POSIX for the past 10+ years, and we have > used in t9xxx (subversion) series of the tests, so we know it is at > least portable across systems that subversion Perl bindings have > been ported to. It is even stronger than that. t9010 is run for everybody (with the exception of the last test, which needs svnadmin). -Peff