From: Jeff King <peff@peff.net>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Elijah Newren <newren@gmail.com>
Subject: Re: [PATCH] t3419: drop EXPENSIVE tests
Date: Sun, 22 Mar 2020 15:19:50 -0400 [thread overview]
Message-ID: <20200322191950.GB671552@coredump.intra.peff.net> (raw)
In-Reply-To: <20200322171111.GB6499@camp.crustytoothpaste.net>
On Sun, Mar 22, 2020 at 05:11:11PM +0000, brian m. carlson wrote:
> > Let's simplify the script by dropping the EXPENSIVE run. That in turn
> > lets us drop the do_tests() wrapper, which lets us consistently use
> > single-quotes for our test snippets. And we can drop the useless
> > test_debug() timings, as well as their run() helper. And finally, while
> > we're here, we can replace the count() helper with the standard
> > test_seq().
>
> I'm also fine with this solution. As long as this test doesn't fail
> with EXPENSIVE, I'm happy.
Just to be clear, this is meant to go on top of your fix, which is
already in next, so I think that part is fixed either way. :)
-Peff
prev parent reply other threads:[~2020-03-22 19:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 21:39 [PATCH] t3419: prevent failure when run with EXPENSIVE brian m. carlson
2020-03-20 21:44 ` Elijah Newren
2020-03-20 21:49 ` brian m. carlson
2020-03-20 22:24 ` Junio C Hamano
2020-03-20 21:52 ` [PATCH v2] " brian m. carlson
2020-03-22 7:51 ` [PATCH] t3419: drop EXPENSIVE tests Jeff King
2020-03-22 17:11 ` brian m. carlson
2020-03-22 19:19 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200322191950.GB671552@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=newren@gmail.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).