git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Benjamin Shropshire <benjamin.shropshire@economicmodeling.com>
Cc: git@vger.kernel.org
Subject: Re: Relative url values in .gitmodules confusingly sensitive to clone via ssh vs https.
Date: Wed, 18 Mar 2020 00:26:30 +0000	[thread overview]
Message-ID: <20200318002630.GA366567@camp.crustytoothpaste.net> (raw)
In-Reply-To: <CAAjm7Ga5JOJ2w=01o1-x-80HMGVaYQQy8SBBb-zJ6MOQAe4SxQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1215 bytes --]

On 2020-03-17 at 18:34:09, Benjamin Shropshire wrote:
> From my perspective, this is a bug.
> 
> If I clone a repo twice like this:
> 
> git clone https://github.com/user/repo.git ./https
> git clone git@github.com:user/repo.git ./ssh
> 
> And if it contains a .gitmodules like this:
> 
> [submodule "x"]
>     path = xxx
>     url = ../../different-user/something.git
> 
> When I `git submodule update --init --recursive` in each, only the
> HTTPS version works. the SSH version confusingly seems to try to find
> something at ~/different-user/something.git or some other path in the
> local file system.
> 
> this seems consistent with the URL parsing resulting in different
> segmentation and thus the ../../ ending up in different places:

Looking at the code, it appears that we don't let you go above the top
of the URL, which makes sense.  So we interpret it as a file system
path.

(And since this SSH format is not technically a URL, we don't have a
root slash, which is probably why this is a problem.)

Does it work if you write the following?

  git clone git@github.com:/user/repo.git ./ssh
-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

  reply	other threads:[~2020-03-18  0:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-17 18:34 Relative url values in .gitmodules confusingly sensitive to clone via ssh vs https Benjamin Shropshire
2020-03-18  0:26 ` brian m. carlson [this message]
2020-03-18 16:02   ` Benjamin Shropshire
2020-03-20  1:18     ` brian m. carlson
2020-03-23  1:11 ` brian m. carlson
2020-03-23 15:09   ` Benjamin Shropshire
2020-03-23 23:53     ` brian m. carlson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200318002630.GA366567@camp.crustytoothpaste.net \
    --to=sandals@crustytoothpaste.net \
    --cc=benjamin.shropshire@economicmodeling.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).