From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id BFDF81F619 for ; Sun, 15 Mar 2020 02:12:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727541AbgCOCMW (ORCPT ); Sat, 14 Mar 2020 22:12:22 -0400 Received: from mslow2.mail.gandi.net ([217.70.178.242]:34202 "EHLO mslow2.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727146AbgCOCMW (ORCPT ); Sat, 14 Mar 2020 22:12:22 -0400 Received: from relay11.mail.gandi.net (unknown [217.70.178.231]) by mslow2.mail.gandi.net (Postfix) with ESMTP id 6CEFC3A7B7B for ; Sat, 14 Mar 2020 17:26:31 +0000 (UTC) Received: from localhost (unknown [103.227.98.14]) (Authenticated sender: me@yadavpratyush.com) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 5A52D100005; Sat, 14 Mar 2020 17:26:03 +0000 (UTC) Date: Sat, 14 Mar 2020 22:56:00 +0530 From: Pratyush Yadav To: Johannes Schindelin via GitGitGadget Cc: git@vger.kernel.org, Johannes Schindelin , Luke Bonanomi , Junio C Hamano Subject: Re: [PATCH v2] git-gui--askpass: coerce answers to UTF-8 on Windows Message-ID: <20200314172600.a6nrm7h3pdzshdv2@yadavpratyush.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 12/03/20 09:31PM, Johannes Schindelin via GitGitGadget wrote: > From: Luke Bonanomi > > This addresses the issue where Git for Windows asks the user for a > password, no credential helper is available, and then Git fails to pick > up non-ASCII characters from the Git GUI helper. > > This can be verified e.g. via > > echo host=http://abc.com | > git -c credential.helper= credential fill > > and then pasting some umlauts. > > The underlying reason is that Git for Windows tries to communicate using > the UTF-8 encoding no matter what the actual current code page is. So > let's indulge Git for Windows and do use that encoding. > > This fixes https://github.com/git-for-windows/git/issues/2215 > > Signed-off-by: Luke Bonanomi > Helped-by: Junio C Hamano > Signed-off-by: Johannes Schindelin Merged. Thanks all. -- Regards, Pratyush Yadav