git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: "Jean-Noël AVILA" <jn.avila@free.fr>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
	Emily Shaffer <emilyshaffer@google.com>
Subject: Re: Regression in v2.26.0-rc0 and Magit
Date: Thu, 12 Mar 2020 16:35:04 -0700	[thread overview]
Message-ID: <20200312233504.GH120942@google.com> (raw)
In-Reply-To: <3091652.KAqcNXvZJ4@cayenne>

Hi,

Jean-Noël AVILA wrote:

> When trying the latest rc with magit, I found that git segfaults
> under Magit with auto-revert enabled. The message in emacs is
>
> Error in post-command-hook (magit-auto-revert-mode-check-buffers):
> (wrong-type-argument number-or-marker-p "Segmentation Fault")
>
> I was able to bisect the issue to commit
> e0020b2f82910f50bc697d86aff70c3796fbdc41 but unfortunately, it seems
> difficult to print the exact command from magit.

Thanks for reporting.  This is fixed by

 commit e6c57b49eb63e77ccf72215229744c4beaf04204 (es/outside-repo-errmsg-hints)
 Author: Emily Shaffer <emilyshaffer@google.com>
 Date:   Mon Mar 2 20:05:06 2020 -0800

    prefix_path: show gitdir if worktree unavailable

Junio, can you fast-track that fix to "master"?  Emily, can you add a
test?

Thanks,
Jonathan

  reply	other threads:[~2020-03-12 23:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-12 22:55 Regression in v2.26.0-rc0 and Magit Jean-Noël AVILA
2020-03-12 23:35 ` Jonathan Nieder [this message]
2020-03-13  0:02   ` Junio C Hamano
2020-03-13 18:27     ` Junio C Hamano
2020-03-13 19:02       ` Jonathan Nieder
2020-03-13 19:07       ` Junio C Hamano
2020-03-14  5:57         ` Kyle Meyer
2020-03-15 10:58       ` SZEDER Gábor
2020-03-15 16:35         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200312233504.GH120942@google.com \
    --to=jrnieder@gmail.com \
    --cc=emilyshaffer@google.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jn.avila@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).