git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Jörn Engel" <joern@purestorage.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: new file mode 160000
Date: Tue, 10 Mar 2020 12:57:24 -0700	[thread overview]
Message-ID: <20200310195724.GE1443@cork> (raw)
In-Reply-To: <xmqqsgighu2p.fsf@gitster.c.googlers.com>

On Tue, Mar 10, 2020 at 12:46:06PM -0700, Junio C Hamano wrote:
> Jörn Engel <joern@purestorage.com> writes:
> 
> > Something weird happened to us and I have no idea how to reproduce it.
> > A developer managed to create a git commit with the following content:
> >
> > diff --git a/foo b/foo
> > new file mode 160000
> > index 000000000000..b7e7816c1266
> > --- /dev/null
> > +++ b/foo
> > @@ -0,0 +1 @@
> > +one line of content
> >
> > File name and content obfuscated, the rest is verbatim from the git
> > commit.
> >
> > Now, file mode 160000 doesn't make sense to me.
> 
> These are gitlinks, that are used to implement submodules.  I cannot
> tell if this is an expected behaviour and there is nothing to worry
> about, or you found a corner case bug, without looking at what the
> "one line of content" says, but if it says "Subproject commit "
> followed by 40-hex object name, then that is a perfectly normal
> behaviour.

That is indeed the content.  So no bug in git.  Thank you!

Given that we don't want to use submodules for this particular
project, can the git server be configured to refuse push requests that
would introduce submodules?

Jörn

--
This above all: to thine own self be true.
-- Shakespeare

  reply	other threads:[~2020-03-10 19:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-10 18:41 new file mode 160000 Jörn Engel
2020-03-10 19:10 ` Andreas Schwab
2020-03-10 19:47   ` Junio C Hamano
2020-03-10 20:09     ` Andreas Schwab
2020-03-11 18:35       ` Junio C Hamano
2020-03-10 19:37 ` Bryan Turner
2020-03-10 19:46 ` Junio C Hamano
2020-03-10 19:57   ` Jörn Engel [this message]
2020-03-10 22:22     ` brian m. carlson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200310195724.GE1443@cork \
    --to=joern@purestorage.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).