From: Benjamin Poirier <benjamin.poirier@gmail.com>
To: Pratyush Yadav <me@yadavpratyush.com>
Cc: git@vger.kernel.org, Jonathan Gilbert <JonathanG@iQmetrix.com>
Subject: Re: [PATCH] git-gui: fix error popup when doing blame -> "Show History Context"
Date: Tue, 3 Mar 2020 09:10:33 +0900 [thread overview]
Message-ID: <20200303001033.GA138670@f3> (raw)
In-Reply-To: <20200302183538.7195-1-me@yadavpratyush.com>
On 2020/03/03 00:05 +0530, Pratyush Yadav wrote:
> In d9c6469 (git-gui: update status bar to track operations, 2019-12-01)
> the call to 'ui_status' in 'do_gitk' was updated to create the newly
> introduced "status bar operation". This allowed this status text so show
> along with other operations happening in parallel, and removed a race
> between all these operations.
>
> But in that refactor, the fact that 'ui_status' checks for the existence
> of 'main_status' was overlooked. This leads to an error message popping
> up when the user selects "Show History Context" from the blame window
> context menu on a source line. The error occurs because when running
> "blame" 'main_status' is not initialized.
>
> So, add a check for the existence of 'main_status' in 'do_gitk'. This
> fix reverts to the original behaviour. In the future, we might want to
> look into a better way of telling 'do_gitk' which status bar to use.
>
> Signed-off-by: Pratyush Yadav <me@yadavpratyush.com>
Tested-by: Benjamin Poirier <benjamin.poirier@gmail.com>
Thank you for looking into this.
prev parent reply other threads:[~2020-03-03 0:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 18:35 [PATCH] git-gui: fix error popup when doing blame -> "Show History Context" Pratyush Yadav
2020-03-03 0:10 ` Benjamin Poirier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200303001033.GA138670@f3 \
--to=benjamin.poirier@gmail.com \
--cc=JonathanG@iQmetrix.com \
--cc=git@vger.kernel.org \
--cc=me@yadavpratyush.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).