From: Taylor Blau <me@ttaylorr.com> To: Jeff King <peff@peff.net> Cc: Junio C Hamano <gitster@pobox.com>, Taylor Blau <me@ttaylorr.com>, Parth Gala via GitGitGadget <gitgitgadget@gmail.com>, git@vger.kernel.org, Parth Gala <parthpgala@gmail.com> Subject: Re: [PATCH 2/5] object.c: lookup_unknown_object() accept 'r' as parameter Date: Fri, 14 Feb 2020 16:00:22 -0800 Message-ID: <20200215000022.GB11400@syl.local> (raw) In-Reply-To: <20200213185235.GA15252@coredump.intra.peff.net> On Thu, Feb 13, 2020 at 01:52:35PM -0500, Jeff King wrote: > On Thu, Feb 13, 2020 at 10:10:45AM -0800, Junio C Hamano wrote: > > > > Right, but my suggestion was that this advice doesn't apply to this > > > particular instance since I don't expect that we'd ever passing > > > something other than 'the_repository'. > > > > > > Specifically, I was worried that we'd get bitten by re-assigning 'r' in > > > the middle of the function and then end up in some odd broken state. > > > > "git fsck" works only in a single, "the", repository, so I guess you > > are right to be worried about unnecessary complexity here. > > I think the end-game for this whole repository transition would be to > get rid of the_repository, though. I.e., I'd envision the progression > something like this: > > 1. Teach all of the library code to take (and operate on) "struct > repository". > > 2. Teach static local functions like this to pass in the_repository. > > 3. Teach top-level commands like cmd_fsck() to pass the_repository to > all of those static local helpers. > > 4. Teach top-level commands to get a real repository pointer, either > from the git.c wrapper (when RUN_SETUP is used) or by calling > setup_git_repository() themselves. > > 5. Grep for the_repository and drop it everywhere. > > Here we're at step 2 now, but declaring "r" makes moving to step 3 just > a little easier. And I think the existence of steps 4 and 5 implies that > it would eventually be worth going through step 3. Ah, the transition to step 3 justifies this, I think. I wasn't aware that steps 3+ existed. If they didn't, I'd stand by my original advice, but given that they do, the approach here makes more sense long-term. > Of course I just wrote those steps down for the first time, so maybe > nobody else shares my vision. ;) Thanks for writing it down. I'm sure that it has been loosely discussed over a while, but this is the first time that I've seen it all in one place. > -Peff Thanks, Taylor
next prev parent reply other threads:[~2020-02-15 0:00 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-12 19:19 [PATCH 0/5] object.c: localize global the_repository variable into r Parth Gala via GitGitGadget 2020-02-12 19:19 ` [PATCH 1/5] object.c: get_max_object_index and get_indexed_object accept 'r' parameter Parth Gala via GitGitGadget 2020-02-12 20:22 ` Taylor Blau 2020-02-12 21:13 ` Eric Sunshine 2020-02-13 5:23 ` parth gala 2020-02-12 19:19 ` [PATCH 2/5] object.c: lookup_unknown_object() accept 'r' as parameter Parth Gala via GitGitGadget 2020-02-12 20:25 ` Taylor Blau 2020-02-12 21:11 ` Junio C Hamano 2020-02-13 18:00 ` Taylor Blau 2020-02-13 18:10 ` Junio C Hamano 2020-02-13 18:52 ` Jeff King 2020-02-15 0:00 ` Taylor Blau [this message] 2020-02-12 19:19 ` [PATCH 3/5] object.c: parse_object_or_die() " Parth Gala via GitGitGadget 2020-02-12 19:19 ` [PATCH 4/5] object.c: clear_object_flags() " Parth Gala via GitGitGadget 2020-02-12 19:19 ` [PATCH 5/5] object.c: clear_commit_marks_all() " Parth Gala via GitGitGadget 2020-02-12 20:18 ` [PATCH 0/5] object.c: localize global the_repository variable into r Taylor Blau 2020-02-13 5:14 ` parth gala
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200215000022.GB11400@syl.local \ --to=me@ttaylorr.com \ --cc=git@vger.kernel.org \ --cc=gitgitgadget@gmail.com \ --cc=gitster@pobox.com \ --cc=parthpgala@gmail.com \ --cc=peff@peff.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
git@vger.kernel.org list mirror (unofficial, one of many) This inbox may be cloned and mirrored by anyone: git clone --mirror http://public-inbox.org/git git clone --mirror http://ou63pmih66umazou.onion/git git clone --mirror http://czquwvybam4bgbro.onion/git git clone --mirror http://hjrcffqmbrq6wope.onion/git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V1 git git/ http://public-inbox.org/git \ git@vger.kernel.org public-inbox-index git Example config snippet for mirrors. Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.version-control.git nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git nntp://news.gmane.io/gmane.comp.version-control.git note: .onion URLs require Tor: https://www.torproject.org/ code repositories for the project(s) associated with this inbox: https://80x24.org/mirrors/git.git AGPL code for this site: git clone https://public-inbox.org/public-inbox.git