From: Taylor Blau <me@ttaylorr.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>
Subject: Re: [PATCH 0/3] Wildcard matching for credentials
Date: Fri, 14 Feb 2020 15:58:22 -0800 [thread overview]
Message-ID: <20200214235822.GA11400@syl.local> (raw)
In-Reply-To: <20200214225929.541306-1-sandals@crustytoothpaste.net>
Hi brian,
On Fri, Feb 14, 2020 at 10:59:26PM +0000, brian m. carlson wrote:
> This series introduces wildcard matching (that is, urlmatch support) for
> credential config options, just like for the http options. This is
> helpful in corporate environments where custom credentials should be
> used across a wide variety of subdomains.
>
> In addition, there's an additional test for urlmatch behavior with
> multiple subdomains and a mailmap update for the email address used in
> this series.
I can imagine that this is perhaps for Git LFS, which I could see
benefiting from this change. My review has nothing to do with my
affiliation (or lack thereof) to LFS.
I gave your patches a review, and they all look quite good to me. Thanks
especially for 2/3, which I would have suggested were it not already
there ;-).
This looks good to me, so please have my:
Reviewed-by: Taylor Blau <me@ttaylorr.com>
> brian m. carlson (3):
> mailmap: add an additional email address for brian m. carlson
> t1300: add test for urlmatch with multiple wildcards
> credential: allow wildcard patterns when matching config
>
> .mailmap | 1 +
> Documentation/gitcredentials.txt | 4 +++-
> credential.c | 41 +++++++++++++++++---------------
> t/t0300-credentials.sh | 20 ++++++++++++++++
> t/t1300-config.sh | 6 +++++
> 5 files changed, 52 insertions(+), 20 deletions(-)
Thanks,
Taylor
next prev parent reply other threads:[~2020-02-14 23:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 22:59 [PATCH 0/3] Wildcard matching for credentials brian m. carlson
2020-02-14 22:59 ` [PATCH 1/3] mailmap: add an additional email address for brian m. carlson brian m. carlson
2020-02-14 22:59 ` [PATCH 2/3] t1300: add test for urlmatch with multiple wildcards brian m. carlson
2020-02-14 22:59 ` [PATCH 3/3] credential: allow wildcard patterns when matching config brian m. carlson
2020-02-16 6:13 ` Jeff King
2020-02-16 20:53 ` brian m. carlson
2020-02-14 23:58 ` Taylor Blau [this message]
2020-02-15 0:13 ` [PATCH 0/3] Wildcard matching for credentials brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200214235822.GA11400@syl.local \
--to=me@ttaylorr.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).