From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 81E271F45E for ; Tue, 11 Feb 2020 19:49:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729967AbgBKTto (ORCPT ); Tue, 11 Feb 2020 14:49:44 -0500 Received: from cloud.peff.net ([104.130.231.41]:57828 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1728723AbgBKTto (ORCPT ); Tue, 11 Feb 2020 14:49:44 -0500 Received: (qmail 9394 invoked by uid 109); 11 Feb 2020 19:49:44 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Tue, 11 Feb 2020 19:49:44 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 1430 invoked by uid 111); 11 Feb 2020 19:58:36 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Tue, 11 Feb 2020 14:58:36 -0500 Authentication-Results: peff.net; auth=none Date: Tue, 11 Feb 2020 14:49:43 -0500 From: Jeff King To: Emily Shaffer Cc: Heba Waly via GitGitGadget , git@vger.kernel.org, Heba Waly Subject: Re: [PATCH] advice: refactor advise API Message-ID: <20200211194943.GC2127797@coredump.intra.peff.net> References: <20200210203725.GA620581@coredump.intra.peff.net> <20200210225528.GD190927@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200210225528.GD190927@google.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Feb 10, 2020 at 02:55:28PM -0800, Emily Shaffer wrote: > I tend to disagree on both counts. I'd personally rather see something > like 'void advise_key(enum advice, char *format, ...)'. Yeah, I don't mind that at all. It's mutually exclusive with not making people add new enums when they want to add new advice types, but as you note we do get some code maintenance benefit by having the variables, even if _adding_ a new one is a slightly larger pain. -Peff