From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: <git@vger.kernel.org>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Junio C Hamano <gitster@pobox.com>
Subject: [PATCH v3 01/21] t/lib-pack: support SHA-256
Date: Fri, 7 Feb 2020 00:52:34 +0000 [thread overview]
Message-ID: <20200207005254.1495851-2-sandals@crustytoothpaste.net> (raw)
In-Reply-To: <20200207005254.1495851-1-sandals@crustytoothpaste.net>
Update the support routines for generating packs to support both SHA-1
and SHA-256. Compute the trailing pack checksum and its length
correctly depending on the algorithm, and look up the object names based
on the algorithm as well. Ensure we initialize the algorithm facts so
that our callers need not do so.
Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
---
t/lib-pack.sh | 35 ++++++++++++++++++++++++++++++-----
1 file changed, 30 insertions(+), 5 deletions(-)
diff --git a/t/lib-pack.sh b/t/lib-pack.sh
index c4d907a450..f3463170b3 100644
--- a/t/lib-pack.sh
+++ b/t/lib-pack.sh
@@ -35,9 +35,11 @@ pack_header () {
# have hardcoded some well-known objects. See the case statements below for the
# complete list.
pack_obj () {
+ test_oid_init
+
case "$1" in
# empty blob
- e69de29bb2d1d6434b8b29ae775ad8c2e48c5391)
+ $EMPTY_BLOB)
case "$2" in
'')
printf '\060\170\234\003\0\0\0\0\1'
@@ -47,7 +49,7 @@ pack_obj () {
;;
# blob containing "\7\76"
- e68fe8129b546b101aee9510c5328e7f21ca1d18)
+ $(test_oid packlib_7_76))
case "$2" in
'')
printf '\062\170\234\143\267\3\0\0\116\0\106'
@@ -59,11 +61,18 @@ pack_obj () {
printf '\234\143\142\142\142\267\003\0\0\151\0\114'
return
;;
+ 37c8e2c15bb22b912e59b43fd51a4f7e9465ed0b5084c5a1411d991cbe630683)
+ printf '\165\67\310\342\301\133\262\53\221\56\131' &&
+ printf '\264\77\325\32\117\176\224\145\355\13\120' &&
+ printf '\204\305\241\101\35\231\34\276\143\6\203\170' &&
+ printf '\234\143\142\142\142\267\003\0\0\151\0\114'
+ return
+ ;;
esac
;;
# blob containing "\7\0"
- 01d7713666f4de822776c7622c10f1b07de280dc)
+ $(test_oid packlib_7_0))
case "$2" in
'')
printf '\062\170\234\143\147\0\0\0\20\0\10'
@@ -75,6 +84,13 @@ pack_obj () {
printf '\143\142\142\142\147\0\0\0\53\0\16'
return
;;
+ 5d8e6fc40f2dab00e6983a48523fe57e621f46434cb58dbd4422fba03380d886)
+ printf '\165\135\216\157\304\17\55\253\0\346\230\72' &&
+ printf '\110\122\77\345\176\142\37\106\103\114\265' &&
+ printf '\215\275\104\42\373\240\63\200\330\206\170\234' &&
+ printf '\143\142\142\142\147\0\0\0\53\0\16'
+ return
+ ;;
esac
;;
esac
@@ -86,7 +102,7 @@ pack_obj () {
then
echo "$1" | git pack-objects --stdout >pack_obj.tmp &&
size=$(wc -c <pack_obj.tmp) &&
- dd if=pack_obj.tmp bs=1 count=$((size - 20 - 12)) skip=12 &&
+ dd if=pack_obj.tmp bs=1 count=$((size - $(test_oid rawsz) - 12)) skip=12 &&
rm -f pack_obj.tmp
return
fi
@@ -97,7 +113,8 @@ pack_obj () {
# Compute and append pack trailer to "$1"
pack_trailer () {
- test-tool sha1 -b <"$1" >trailer.tmp &&
+ test_oid_init &&
+ test-tool $(test_oid algo) -b <"$1" >trailer.tmp &&
cat trailer.tmp >>"$1" &&
rm -f trailer.tmp
}
@@ -108,3 +125,11 @@ pack_trailer () {
clear_packs () {
rm -f .git/objects/pack/*
}
+
+test_oid_cache <<-EOF
+packlib_7_0 sha1:01d7713666f4de822776c7622c10f1b07de280dc
+packlib_7_0 sha256:37c8e2c15bb22b912e59b43fd51a4f7e9465ed0b5084c5a1411d991cbe630683
+
+packlib_7_76 sha1:e68fe8129b546b101aee9510c5328e7f21ca1d18
+packlib_7_76 sha256:5d8e6fc40f2dab00e6983a48523fe57e621f46434cb58dbd4422fba03380d886
+EOF
next prev parent reply other threads:[~2020-02-07 0:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 0:52 [PATCH v3 00/21] SHA-256 test fixes, part 8 brian m. carlson
2020-02-07 0:52 ` brian m. carlson [this message]
2020-02-07 0:52 ` [PATCH v3 02/21] t3206: make hash size independent brian m. carlson
2020-02-07 0:52 ` [PATCH v3 03/21] t3308: make test work with SHA-256 brian m. carlson
2020-02-07 0:52 ` [PATCH v3 04/21] t3309: " brian m. carlson
2020-02-07 0:52 ` [PATCH v3 05/21] t3310: " brian m. carlson
2020-02-07 0:52 ` [PATCH v3 06/21] t3311: " brian m. carlson
2020-02-07 0:52 ` [PATCH v3 07/21] t4013: make test hash independent brian m. carlson
2020-02-07 0:52 ` [PATCH v3 08/21] t4211: move SHA-1-specific test cases into a directory brian m. carlson
2020-02-07 0:52 ` [PATCH v3 09/21] t4211: add test cases for SHA-256 brian m. carlson
2020-02-07 0:52 ` [PATCH v3 10/21] t4060: make test work with SHA-256 brian m. carlson
2020-02-07 0:52 ` [PATCH v3 11/21] t5302: make hash size independent brian m. carlson
2020-02-07 0:52 ` [PATCH v3 12/21] t5309: make test hash independent brian m. carlson
2020-02-07 0:52 ` [PATCH v3 13/21] t5313: " brian m. carlson
2020-02-07 0:52 ` [PATCH v3 14/21] t5321: " brian m. carlson
2020-02-07 0:52 ` [PATCH v3 15/21] t5515: " brian m. carlson
2020-02-07 0:52 ` [PATCH v3 16/21] t5318: update for SHA-256 brian m. carlson
2020-02-07 0:52 ` [PATCH v3 17/21] t5607: make hash size independent brian m. carlson
2020-02-07 0:52 ` [PATCH v3 18/21] t5703: make test work with SHA-256 brian m. carlson
2020-02-07 0:52 ` [PATCH v3 19/21] t6000: abstract away SHA-1-specific constants brian m. carlson
2020-02-07 0:52 ` [PATCH v3 20/21] t6006: make hash size independent brian m. carlson
2020-02-07 0:52 ` [PATCH v3 21/21] t6024: update for SHA-256 brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200207005254.1495851-2-sandals@crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).