From: Jeff King <peff@peff.net>
To: Taylor Blau <me@ttaylorr.com>
Cc: git@vger.kernel.org, dstolee@microsoft.com, gitster@pobox.com
Subject: Re: [PATCH 0/6] commit-graph: use 'struct object_directory *' everywhere
Date: Fri, 31 Jan 2020 05:30:08 -0500 [thread overview]
Message-ID: <20200131103008.GD2916051@coredump.intra.peff.net> (raw)
In-Reply-To: <cover.1580424766.git.me@ttaylorr.com>
On Thu, Jan 30, 2020 at 03:00:40PM -0800, Taylor Blau wrote:
> This series became a little bit longer than I was expecting it to be, so
> here is the high-level structure:
>
> - 1/6 fixes a bug in a test that would cause a subsequent failure if
> unaddressed.
>
> - 2/6 does the first half of the removal by using 'struct
> object_directory *'s within the 'commit_graph' structure.
>
> - 4/6 does the second half by removing 'char *object_dir' usage in the
> 'write_commit_graph_context' structure.
>
> - 5/6 ties 2/6 and 4/6 together by removing all path normalization
> completely, fixing the uninitialized read bug.
>
> - And 6/6 cleans up.
With the exception of the patch-ordering discussion in the sub-thread
with Martin, this looks good to me.
Patch 3 is a change in user-visible behavior, as it restricts how
--object-dir can be used (it must be the main object-dir or an alternate
within the repository). I don't _think_ anybody would care, as the
semantics of those options seemed kind of ill-defined to me in the first
place. But it's worth calling out as a potential risk. I suppose the
alternative is to make a one-off fake "struct object_directory" within
the process that isn't connected to the repository. But if nobody cares,
I'd just as soon avoid that.
One other funny thing with this series: the Date headers of your patches
seem out of order. They ordering in your cover letter here is fine and
presumably reflects the commit topology:
> Taylor Blau (6):
> t5318: don't pass non-object directory to '--object-dir'
> commit-graph.h: store object directory in 'struct commit_graph'
> builtin/commit-graph.c: die() with unknown '--object-dir'
> commit-graph.h: store an odb in 'struct write_commit_graph_context'
> commit-graph.c: remove path normalization, comparison
> commit-graph.h: use odb in 'load_commit_graph_one_fd_st'
but the Date headers in order of 1-6 are:
Date: Thu, 30 Jan 2020 15:00:43 -0800
Date: Thu, 30 Jan 2020 15:00:50 -0800
Date: Thu, 30 Jan 2020 15:00:54 -0800
Date: Thu, 30 Jan 2020 15:00:52 -0800
Date: Thu, 30 Jan 2020 15:00:45 -0800
Date: Thu, 30 Jan 2020 15:00:47 -0800
It's like your sending script rewrites the Date header and puts a
2-second bump between each one (which is good, and what git-send-email
does), but got fed the patches in the wrong order (perhaps their
_original_ date order, if there was clean-up rebasing).
-Peff
next prev parent reply other threads:[~2020-01-31 10:30 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 23:00 [PATCH 0/6] commit-graph: use 'struct object_directory *' everywhere Taylor Blau
2020-01-30 23:00 ` [PATCH 1/6] t5318: don't pass non-object directory to '--object-dir' Taylor Blau
2020-01-30 23:00 ` [PATCH 5/6] commit-graph.c: remove path normalization, comparison Taylor Blau
2020-01-30 23:00 ` [PATCH 6/6] commit-graph.h: use odb in 'load_commit_graph_one_fd_st' Taylor Blau
2020-01-30 23:00 ` [PATCH 2/6] commit-graph.h: store object directory in 'struct commit_graph' Taylor Blau
2020-01-31 6:52 ` Martin Ågren
2020-01-31 10:20 ` Jeff King
2020-01-31 19:19 ` Martin Ågren
2020-02-03 4:36 ` Taylor Blau
2020-02-03 8:36 ` Jeff King
2020-01-31 20:49 ` Junio C Hamano
2020-02-03 3:58 ` Taylor Blau
2020-01-30 23:00 ` [PATCH 4/6] commit-graph.h: store an odb in 'struct write_commit_graph_context' Taylor Blau
2020-01-30 23:00 ` [PATCH 3/6] builtin/commit-graph.c: die() with unknown '--object-dir' Taylor Blau
2020-01-31 10:30 ` Jeff King [this message]
2020-01-31 13:22 ` [PATCH 0/6] commit-graph: use 'struct object_directory *' everywhere Derrick Stolee
2020-02-03 4:38 ` Taylor Blau
2020-02-03 21:17 ` [PATCH v2 0/5] " Taylor Blau
2020-02-03 21:17 ` [PATCH v2 1/5] t5318: don't pass non-object directory to '--object-dir' Taylor Blau
2020-02-03 21:17 ` [PATCH v2 2/5] commit-graph.h: store an odb in 'struct write_commit_graph_context' Taylor Blau
2020-02-04 5:51 ` Taylor Blau
2020-02-04 19:54 ` Junio C Hamano
2020-02-04 21:28 ` Taylor Blau
2020-02-04 21:44 ` Junio C Hamano
2020-02-03 21:18 ` [PATCH v2 3/5] commit-graph.h: store object directory in 'struct commit_graph' Taylor Blau
2020-02-03 21:18 ` [PATCH v2 4/5] commit-graph.c: remove path normalization, comparison Taylor Blau
2020-02-03 21:18 ` [PATCH v2 5/5] commit-graph.h: use odb in 'load_commit_graph_one_fd_st' Taylor Blau
2020-02-05 12:30 ` [PATCH v2 0/5] commit-graph: use 'struct object_directory *' everywhere Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200131103008.GD2916051@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).