From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH] Makefile: use compat regex with SANITIZE=address
Date: Fri, 17 Jan 2020 12:49:31 -0500 [thread overview]
Message-ID: <20200117174931.GA8958@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqqr1zydlwt.fsf@gitster-ct.c.googlers.com>
On Fri, Jan 17, 2020 at 09:37:22AM -0800, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > Recent versions of the gcc and clang Address Sanitizer produce test
> > failures related to regexec(). This triggers with gcc-10 and clang-8
> > (but not gcc-9 nor clang-7). Running:
> >
> > make CC=gcc-10 SANITIZE=address test
> >
> > results in failures in t4018, t3206, and t4062.
> [...]
> I guess we should treat this the same way as the recent vcproj "fix"
> by Dscho, i.e. fast-track to 'maint' to ensure that all public
> integration branches has it soonish?
I don't think there's a huge rush. It only triggers ASan and recent
compilers, so AFAIK nobody has been hitting this in CI. I occasionally
test with whatever is the most recent compiler in Debian unstable to see
if it turns up any interesting new warnings or errors (but gcc-9 is
still the default there).
-Peff
next prev parent reply other threads:[~2020-01-17 17:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 17:51 [PATCH] Makefile: use compat regex with SANITIZE=address Jeff King
2020-01-16 18:34 ` [PATCH] t4018: drop "debugging" cat from hunk-header tests Jeff King
2020-01-16 22:56 ` Jonathan Nieder
2020-01-17 17:37 ` [PATCH] Makefile: use compat regex with SANITIZE=address Junio C Hamano
2020-01-17 17:49 ` Jeff King [this message]
2020-01-17 23:39 ` brian m. carlson
2020-01-18 3:34 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200117174931.GA8958@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).