From: Jonathan Nieder <jrnieder@gmail.com>
To: Derrick Stolee <dstolee@microsoft.com>
Cc: git@vger.kernel.org, Kevin.Willford@microsoft.com, newren@gmail.com
Subject: Re: [PATCH] clean: demonstrate a bug with pathspecs
Date: Thu, 16 Jan 2020 00:03:12 +0000 [thread overview]
Message-ID: <20200116000312.GD146834@google.com> (raw)
In-Reply-To: <pull.526.git.1579119946211.gitgitgadget@gmail.com>
Hi,
Derrick Stolee wrote:
> b9660c1 (dir: fix checks on common prefix directory, 2019-12-19)
> modified the way pathspecs are handled when handling a directory
> during "git clean -f <path>". While this improved the behavior
> for known test breakages, it also regressed in how the clean
> command handles cleaning a specified file.
>
> Add a test case that demonstrates this behavior. This test passes
> before b9660c1 then fails after.
Can this commit message say a little more about the nature of the
bug? For example, what kind of workflow does this come up in for
end users?
[...]
> While integrating v2.25.0 into the microsoft/git fork, one of our VFS
> for Git functional tests started failing.
This is also useful information to put in the commit message: e.g.
"Noticed via VFS for Git's functional test <test name>". It provides
useful context when looking at such a patch later.
[...]
> Elijah is CC'd in case he still has
> context on this area.
Thanks and hope that helps,
Jonathan
next prev parent reply other threads:[~2020-01-16 0:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 20:25 [PATCH] clean: demonstrate a bug with pathspecs Derrick Stolee via GitGitGadget
2020-01-15 23:30 ` Kyle Meyer
2020-01-16 1:33 ` Derrick Stolee
2020-01-16 0:03 ` Jonathan Nieder [this message]
2020-01-16 1:43 ` Derrick Stolee
2020-01-16 0:38 ` Elijah Newren
2020-01-16 1:23 ` Derrick Stolee
2020-01-16 18:01 ` Elijah Newren
2020-01-16 20:20 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200116000312.GD146834@google.com \
--to=jrnieder@gmail.com \
--cc=Kevin.Willford@microsoft.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=newren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).