From: Jeff King <peff@peff.net>
To: "Patrick Marlier (pamarlie)" <pamarlie@cisco.com>
Cc: Jonathan Tan <jonathantanmy@google.com>,
"git@vger.kernel.org" <git@vger.kernel.org>,
Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: [PATCH] send-pack: use OBJECT_INFO_QUICK to check negative objects
Date: Tue, 10 Dec 2019 15:27:32 -0500 [thread overview]
Message-ID: <20191210202732.GA11733@coredump.intra.peff.net> (raw)
In-Reply-To: <CH2PR11MB4294C33B1CC956D5BF6AAB81CF5B0@CH2PR11MB4294.namprd11.prod.outlook.com>
On Tue, Dec 10, 2019 at 04:16:40PM +0000, Patrick Marlier (pamarlie) wrote:
> > From: Jeff King <peff@peff.net>
> > I'll be curious to see real-world numbers from Patrick's case).
>
> Here the real-world case (40 pushes)
>
> released
> average 00:08:35.54
> median 00:07:37.88
> max 00:15:30.26
>
> patched
> average 00:06:45.67
> median 00:05:39.57
> max 00:16:15.46
>
> Note our production is using 2.19 so I back-ported the patch (need to
> include 2 other patches).
You may see much better performance if you move to 2.21 or higher, or
backport the topic from 3b2f8a02fa (Merge branch 'jk/loose-object-cache',
2019-01-04). That would cause most of your negative lookups to not touch
the filesystem at all.
-Peff
prev parent reply other threads:[~2019-12-10 20:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 13:12 Push a ref to a remote with many refs Patrick Marlier (pamarlie)
2019-11-25 16:22 ` Patrick Marlier (pamarlie)
2019-11-27 12:32 ` [PATCH] send-pack: use OBJECT_INFO_QUICK to check negative objects Jeff King
2019-11-29 9:22 ` Patrick Marlier (pamarlie)
2019-11-30 17:08 ` Junio C Hamano
2019-12-03 23:20 ` Jeff King
2019-12-04 20:53 ` Jonathan Tan
2019-12-04 21:37 ` Junio C Hamano
2019-12-04 3:55 ` Jonathan Nieder
2019-12-04 4:05 ` Jeff King
2019-12-10 16:16 ` Patrick Marlier (pamarlie)
2019-12-10 20:27 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191210202732.GA11733@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
--cc=jrnieder@gmail.com \
--cc=pamarlie@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).