From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.2 required=3.0 tests=AWL,BAYES_00,BODY_8BITS, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 263461F463 for ; Thu, 5 Dec 2019 20:40:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729240AbfLEUkz (ORCPT ); Thu, 5 Dec 2019 15:40:55 -0500 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:55497 "EHLO relay5-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729145AbfLEUky (ORCPT ); Thu, 5 Dec 2019 15:40:54 -0500 X-Originating-IP: 157.36.201.94 Received: from localhost (unknown [157.36.201.94]) (Authenticated sender: me@yadavpratyush.com) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id D7A2C1C0005; Thu, 5 Dec 2019 20:40:50 +0000 (UTC) Date: Fri, 6 Dec 2019 02:10:46 +0530 From: Pratyush Yadav To: Junio C Hamano Cc: Paul Mackerras , "git@vger.kernel.org" , =?utf-8?B?5Yqg6Jek5LiA5Y2a?= Subject: Re: [PATCH] gitk branch name encoding utf-8 probrem Message-ID: <20191205204046.waceacp5b3t5djrc@yadavpratyush.com> References: <20191204222921.GB195537@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 05/12/19 12:28PM, Junio C Hamano wrote: > 加藤一博 writes: > > > fix branch name encoding error on gitk. > > > > git checkout -b '漢字' > > gitk show branch name broken like this '貍「蟄' > > fix this problem. > > Paul (the gitk maintainer), the patch text itself does look > reasonable. > > After "git checkout -b '漢字'" to create a branch with UTF-8 > character in it, "gitk" shows the branch name incorrectly, as it > forgets to turns the bytes read from the "git show-ref" command Minor typo: s/turns/turn/ > into Unicode characters. > > is how I would phrase the log message. > > Thanks. -- Regards, Pratyush Yadav